You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/10/11 14:23:17 UTC
[GitHub] [nifi] deekim opened a new pull request #4595: refactor CountText to ignore whitespace words when counting
deekim opened a new pull request #4595:
URL: https://github.com/apache/nifi/pull/4595
#### Description of PR
Was going through the repo to find some `todo`s to clean up and this one seemed pretty straightforward.
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
→ I wasn't sure if I needed to create a new ticket for something like this,
or just reference the original:
- [NIFI-4727](https://issues.apache.org/jira/browse/NIFI-4727)
- #2371
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
I was having a lot of issues running this command locally, and ended up just running:
```bash
mvn -Pcontrib-check -Drat.skip=true -Dtest=CountTextTest -DfailIfNoTests=false install
```
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] deekim commented on pull request #4595: NIFI-7916: refactor CountText to ignore whitespace words when counting
Posted by GitBox <gi...@apache.org>.
deekim commented on pull request #4595:
URL: https://github.com/apache/nifi/pull/4595#issuecomment-707661341
Done! Appreciate the review @pvillard31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4595: refactor CountText to ignore whitespace words when counting
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4595:
URL: https://github.com/apache/nifi/pull/4595#issuecomment-707619071
Hey @deekim - thanks for your contribution. Can you create a dedicated JIRA on https://issues.apache.org/jira/browse/NIFI and reference it in the title of your pull request? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4595: NIFI-7916: refactor CountText to ignore whitespace words when counting
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4595:
URL: https://github.com/apache/nifi/pull/4595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] deekim edited a comment on pull request #4595: NIFI-7916: refactor CountText to ignore whitespace words when counting
Posted by GitBox <gi...@apache.org>.
deekim edited a comment on pull request #4595:
URL: https://github.com/apache/nifi/pull/4595#issuecomment-707661341
> Hey @deekim - thanks for your contribution. Can you create a dedicated JIRA on https://issues.apache.org/jira/browse/NIFI and reference it in the title of your pull request? Thanks!
Done! Appreciate the review @pvillard31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org