[GitHub] [pinot] PrachiKhobragade commented on a diff in pull request #10238: Fix race condition on removing aged deleted segments

["PrachiKhobragade (via GitHub)" <gi...@apache.org>]

PrachiKhobragade commented on code in PR #10238:
URL: https://github.com/apache/pinot/pull/10238#discussion_r1099570625


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/URIUtils.java:
##########
@@ -70,6 +70,14 @@ public static String getPath(String basePath, String... parts) {
     return stringJoiner.toString();
   }
 
+  /**
+   * Returns the last part for the given path split by the file separator.
+   * If the file separator is not found, returns the whole path as the last part.
+   */
+  public static String getLastPart(String path) {

Review Comment:
   If used at other places, the URI might have query parameters. Should those be removed? Or add a test case for "?..="



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org