You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Sid Anand <sa...@apache.org> on 2018/09/11 00:21:23 UTC
Cold-case PRs
Folks!
It's around that time (over 200 PRs with some 2 years old) when we need to
consider closing some abandoned PRs. We have a lot more active maintainers
now today than we had 1 or 2 years ago, we are better able to keep up with
new PR demand, but it's still not perfect.
I've created a GitHub Label : *Potential_Cold_Case_PR.*
I've started labeling some old PRs likewise and pinging the submitters.
Anyone in the community can help with labeling and pinging submitters. If
we (maintainers) find the PR abandoned (i.e. no updates from submitters for
a few days), we can close the PRs.
Additionally, if the JIRAs themselves are obsolete and no longer apply, we
can consider closing the JIRAs as obsolete.
Here's one example :
https://github.com/apache/incubator-airflow/pulls/vijaysbhat
-s
Re: Cold-case PRs
Posted by Sid Anand <sa...@apache.org>.
Looks cool Max.
Filed an Infra ticket:
https://issues.apache.org/jira/browse/INFRA-17005
Created a Jira to add a policy file: .github/stale.yml
<goog_1485221928>
https://issues.apache.org/jira/browse/AIRFLOW-3040
& raised a PR : https://github.com/apache/incubator-airflow/pull/3883
We can manage the Jira backlog separately.
-s
On Mon, Sep 10, 2018 at 8:38 PM Maxime Beauchemin <
maximebeauchemin@gmail.com> wrote:
> It doesn't deal with Jiras, just PRs and GH issues (which we don't use...)
>
> Max
>
> On Mon, Sep 10, 2018 at 6:58 PM Sid Anand <sa...@apache.org> wrote:
>
> > Max,
> > How do these manage the JIRAs?
> >
> > -s
> >
> > On Mon, Sep 10, 2018 at 6:14 PM Maxime Beauchemin <
> > maximebeauchemin@gmail.com> wrote:
> >
> > > I've used https://github.com/bstriner/github-bot-close-inactive-issues
> > in
> > > the past to auto-close issues / PRs based on a policy around
> inactivity.
> > It
> > > worked alright.
> > >
> > > There's also https://github.com/probot/stale which seems to be one of
> > the
> > > leading solutions, but it may require an Apache INFRA ticket to make
> the
> > > integration work (if they'll allow it).
> > >
> > > Max
> > >
> > > On Mon, Sep 10, 2018 at 5:21 PM Sid Anand <sa...@apache.org> wrote:
> > >
> > > > Folks!
> > > > It's around that time (over 200 PRs with some 2 years old) when we
> need
> > > to
> > > > consider closing some abandoned PRs. We have a lot more active
> > > maintainers
> > > > now today than we had 1 or 2 years ago, we are better able to keep up
> > > with
> > > > new PR demand, but it's still not perfect.
> > > >
> > > > I've created a GitHub Label : *Potential_Cold_Case_PR.*
> > > >
> > > > I've started labeling some old PRs likewise and pinging the
> submitters.
> > > > Anyone in the community can help with labeling and pinging
> submitters.
> > If
> > > > we (maintainers) find the PR abandoned (i.e. no updates from
> submitters
> > > for
> > > > a few days), we can close the PRs.
> > > >
> > > > Additionally, if the JIRAs themselves are obsolete and no longer
> apply,
> > > we
> > > > can consider closing the JIRAs as obsolete.
> > > >
> > > > Here's one example :
> > > > https://github.com/apache/incubator-airflow/pulls/vijaysbhat
> > > >
> > > > -s
> > > >
> > >
> >
>
Re: Cold-case PRs
Posted by Maxime Beauchemin <ma...@gmail.com>.
It doesn't deal with Jiras, just PRs and GH issues (which we don't use...)
Max
On Mon, Sep 10, 2018 at 6:58 PM Sid Anand <sa...@apache.org> wrote:
> Max,
> How do these manage the JIRAs?
>
> -s
>
> On Mon, Sep 10, 2018 at 6:14 PM Maxime Beauchemin <
> maximebeauchemin@gmail.com> wrote:
>
> > I've used https://github.com/bstriner/github-bot-close-inactive-issues
> in
> > the past to auto-close issues / PRs based on a policy around inactivity.
> It
> > worked alright.
> >
> > There's also https://github.com/probot/stale which seems to be one of
> the
> > leading solutions, but it may require an Apache INFRA ticket to make the
> > integration work (if they'll allow it).
> >
> > Max
> >
> > On Mon, Sep 10, 2018 at 5:21 PM Sid Anand <sa...@apache.org> wrote:
> >
> > > Folks!
> > > It's around that time (over 200 PRs with some 2 years old) when we need
> > to
> > > consider closing some abandoned PRs. We have a lot more active
> > maintainers
> > > now today than we had 1 or 2 years ago, we are better able to keep up
> > with
> > > new PR demand, but it's still not perfect.
> > >
> > > I've created a GitHub Label : *Potential_Cold_Case_PR.*
> > >
> > > I've started labeling some old PRs likewise and pinging the submitters.
> > > Anyone in the community can help with labeling and pinging submitters.
> If
> > > we (maintainers) find the PR abandoned (i.e. no updates from submitters
> > for
> > > a few days), we can close the PRs.
> > >
> > > Additionally, if the JIRAs themselves are obsolete and no longer apply,
> > we
> > > can consider closing the JIRAs as obsolete.
> > >
> > > Here's one example :
> > > https://github.com/apache/incubator-airflow/pulls/vijaysbhat
> > >
> > > -s
> > >
> >
>
Re: Cold-case PRs
Posted by Sid Anand <sa...@apache.org>.
Max,
How do these manage the JIRAs?
-s
On Mon, Sep 10, 2018 at 6:14 PM Maxime Beauchemin <
maximebeauchemin@gmail.com> wrote:
> I've used https://github.com/bstriner/github-bot-close-inactive-issues in
> the past to auto-close issues / PRs based on a policy around inactivity. It
> worked alright.
>
> There's also https://github.com/probot/stale which seems to be one of the
> leading solutions, but it may require an Apache INFRA ticket to make the
> integration work (if they'll allow it).
>
> Max
>
> On Mon, Sep 10, 2018 at 5:21 PM Sid Anand <sa...@apache.org> wrote:
>
> > Folks!
> > It's around that time (over 200 PRs with some 2 years old) when we need
> to
> > consider closing some abandoned PRs. We have a lot more active
> maintainers
> > now today than we had 1 or 2 years ago, we are better able to keep up
> with
> > new PR demand, but it's still not perfect.
> >
> > I've created a GitHub Label : *Potential_Cold_Case_PR.*
> >
> > I've started labeling some old PRs likewise and pinging the submitters.
> > Anyone in the community can help with labeling and pinging submitters. If
> > we (maintainers) find the PR abandoned (i.e. no updates from submitters
> for
> > a few days), we can close the PRs.
> >
> > Additionally, if the JIRAs themselves are obsolete and no longer apply,
> we
> > can consider closing the JIRAs as obsolete.
> >
> > Here's one example :
> > https://github.com/apache/incubator-airflow/pulls/vijaysbhat
> >
> > -s
> >
>
Re: Cold-case PRs
Posted by Maxime Beauchemin <ma...@gmail.com>.
I've used https://github.com/bstriner/github-bot-close-inactive-issues in
the past to auto-close issues / PRs based on a policy around inactivity. It
worked alright.
There's also https://github.com/probot/stale which seems to be one of the
leading solutions, but it may require an Apache INFRA ticket to make the
integration work (if they'll allow it).
Max
On Mon, Sep 10, 2018 at 5:21 PM Sid Anand <sa...@apache.org> wrote:
> Folks!
> It's around that time (over 200 PRs with some 2 years old) when we need to
> consider closing some abandoned PRs. We have a lot more active maintainers
> now today than we had 1 or 2 years ago, we are better able to keep up with
> new PR demand, but it's still not perfect.
>
> I've created a GitHub Label : *Potential_Cold_Case_PR.*
>
> I've started labeling some old PRs likewise and pinging the submitters.
> Anyone in the community can help with labeling and pinging submitters. If
> we (maintainers) find the PR abandoned (i.e. no updates from submitters for
> a few days), we can close the PRs.
>
> Additionally, if the JIRAs themselves are obsolete and no longer apply, we
> can consider closing the JIRAs as obsolete.
>
> Here's one example :
> https://github.com/apache/incubator-airflow/pulls/vijaysbhat
>
> -s
>