You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/26 07:13:31 UTC
[GitHub] [calcite] xy2953396112 opened a new pull request #1692:
[CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
xy2953396112 opened a new pull request #1692: [CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1692
JIRA:https://issues.apache.org/jira/browse/CALCITE-3632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] jinxing64 commented on a change in pull request #1692:
[CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on a change in pull request #1692: [CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1692#discussion_r361420775
##########
File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java
##########
@@ -2857,6 +2858,26 @@ private void checkSatisfiable(RexNode e, String s) {
checkMaterialize(mv, query);
}
+ @Test public void testIntersectToIntersect0() {
+ final String mv = ""
+ + "select \"deptno\" from\n"
+ + "\"emps\" intersect select \"deptno\" from \"depts\"";
+ final String query = ""
+ + "select \"deptno\" from\n"
+ + "\"depts\" intersect select \"deptno\" from \"emps\"";
+ checkMaterialize(mv, query, true);
+ }
+
+ @Test public void testIntersectToIntersect1() {
Review comment:
How about format like below:
```
select deptno from emps
intersect
select deptno from depts;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] xy2953396112 commented on a change in pull request #1692:
[CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #1692: [CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1692#discussion_r361593369
##########
File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java
##########
@@ -2857,6 +2858,26 @@ private void checkSatisfiable(RexNode e, String s) {
checkMaterialize(mv, query);
}
+ @Test public void testIntersectToIntersect0() {
+ final String mv = ""
+ + "select \"deptno\" from\n"
+ + "\"emps\" intersect select \"deptno\" from \"depts\"";
+ final String query = ""
+ + "select \"deptno\" from\n"
+ + "\"depts\" intersect select \"deptno\" from \"emps\"";
+ checkMaterialize(mv, query, true);
+ }
+
+ @Test public void testIntersectToIntersect1() {
Review comment:
thanks, update code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] zabetak closed pull request #1692: [CALCITE-3632] Add
IntersectToIntersectUnify Rule in SubstitutionVisitor
Posted by GitBox <gi...@apache.org>.
zabetak closed pull request #1692: [CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] jinxing64 commented on issue #1692: [CALCITE-3632] Add
IntersectToIntersectUnify Rule in SubstitutionVisitor
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on issue #1692: [CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1692#issuecomment-569029502
Just minor comments ~
BTW, this is another case that tests added just for SubstitutionVisitor ~
If committer starts review this one, it will be great that https://github.com/apache/calcite/pull/1560 can also be taken into consideration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] jinxing64 commented on a change in pull request #1692:
[CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on a change in pull request #1692: [CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1692#discussion_r361420368
##########
File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java
##########
@@ -2857,6 +2858,26 @@ private void checkSatisfiable(RexNode e, String s) {
checkMaterialize(mv, query);
}
+ @Test public void testIntersectToIntersect0() {
+ final String mv = ""
+ + "select \"deptno\" from\n"
+ + "\"emps\" intersect select \"deptno\" from \"depts\"";
Review comment:
Redundant spaces ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services