You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/25 18:50:22 UTC

[GitHub] [arrow-rs] alamb commented on a change in pull request #712: Parquet Derive: remove obscure feature flags, make chrono time emit converted type

alamb commented on a change in pull request #712:
URL: https://github.com/apache/arrow-rs/pull/712#discussion_r696022605



##########
File path: parquet_derive/src/parquet_field.rs
##########
@@ -534,13 +545,23 @@ impl Type {
                 })) }
             }
             "NaiveDate" => quote! { Some(LogicalType::DATE(Default::default())) },
+            "NaiveDateTime" => quote! { None },

Review comment:
       I double checked and I agree there does not seem to be any `DATETIME` logical type in https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/parquet/src/basic.rs?L166




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org