You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/28 19:44:34 UTC
[GitHub] [superset] ktmud opened a new pull request, #20905: fix(sqllab): hide tracking url when fetching
ktmud opened a new pull request, #20905:
URL: https://github.com/apache/superset/pull/20905
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Hide tracking url when SQL Lab is fetching query results or when query is successful. Also fix missing margin when progress bar hasn't show up.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### Before
<img width="447" alt="Xnip2022-07-28_12-42-11" src="https://user-images.githubusercontent.com/335541/181624062-7a20a284-c0d7-4a80-a290-a3af282f16eb.png">
#### After
<img width="451" alt="Xnip2022-07-28_12-41-41" src="https://user-images.githubusercontent.com/335541/181624047-f0bfeba0-4427-4768-b038-1901da3afbe0.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20905: fix(sqllab): hide tracking url when fetching
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20905:
URL: https://github.com/apache/superset/pull/20905#issuecomment-1199067012
# [Codecov](https://codecov.io/gh/apache/superset/pull/20905?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20905](https://codecov.io/gh/apache/superset/pull/20905?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a830d2) into [master](https://codecov.io/gh/apache/superset/commit/8d0d778d1a00f8f06103c001c071f5a012a40649?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d0d778) will **decrease** coverage by `0.00%`.
> The diff coverage is `20.00%`.
```diff
@@ Coverage Diff @@
## master #20905 +/- ##
==========================================
- Coverage 66.31% 66.31% -0.01%
==========================================
Files 1758 1758
Lines 67008 67010 +2
Branches 7107 7109 +2
==========================================
Hits 44437 44437
Misses 20749 20749
- Partials 1822 1824 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.00% <20.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20905?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...frontend/src/SqlLab/components/ResultSet/index.tsx](https://codecov.io/gh/apache/superset/pull/20905/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC9pbmRleC50c3g=) | `50.68% <20.00%> (-0.71%)` | :arrow_down: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #20905: fix(sqllab): hide tracking url when fetching
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #20905:
URL: https://github.com/apache/superset/pull/20905#discussion_r940587480
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -80,6 +78,14 @@ interface ResultSetState {
alertIsOpen: boolean;
}
+const Styles = styled.div`
+ position: relative;
+ minheight: 100px;
Review Comment:
I think this needs to be `min-height` @ktmud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #20905: fix(sqllab): hide tracking url when fetching
Posted by GitBox <gi...@apache.org>.
ktmud merged PR #20905:
URL: https://github.com/apache/superset/pull/20905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org