You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/08/12 02:33:01 UTC

[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #2848: Feature#2715

KomachiSion commented on a change in pull request #2848: Feature#2715
URL: https://github.com/apache/incubator-shardingsphere/pull/2848#discussion_r312767197
 
 

 ##########
 File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/QueryResultMetaData.java
 ##########
 @@ -70,8 +71,8 @@ public QueryResultMetaData(final ResultSetMetaData resultSetMetaData) {
     }
     
     @SneakyThrows
-    private Map<String, Integer> getColumnLabelAndIndexMap() {
-        Map<String, Integer> result = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
+    private Multimap<String, Integer> getColumnLabelAndIndexMap() {
+        Multimap<String, Integer> result = HashMultimap.create();
 
 Review comment:
   The Mulitmap is `CASE_SENSITIVE` may be cause some bug like #2152 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services