You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2024/11/22 21:08:57 UTC
[PR] Modified accumulo-cluster to allow conf dir and extra args per group [accumulo]
dlmarion opened a new pull request, #5099:
URL: https://github.com/apache/accumulo/pull/5099
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified accumulo-cluster to allow conf dir and extra args per group [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5099:
URL: https://github.com/apache/accumulo/pull/5099#issuecomment-2500746254
Closing in favor of #5111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified accumulo-cluster to allow conf dir and extra args per group [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #5099:
URL: https://github.com/apache/accumulo/pull/5099#discussion_r1856886535
##########
assemble/bin/accumulo-cluster:
##########
@@ -651,28 +639,46 @@ function main() {
fi
cat <<EOF >"$conf"/cluster.yaml
manager:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
monitor:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
gc:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
Review Comment:
Added documentation in 2e182d1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified accumulo-cluster to allow conf dir and extra args per group [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5099:
URL: https://github.com/apache/accumulo/pull/5099#discussion_r1855220498
##########
assemble/bin/accumulo-cluster:
##########
@@ -651,28 +639,46 @@ function main() {
fi
cat <<EOF >"$conf"/cluster.yaml
manager:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
monitor:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
gc:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
Review Comment:
Would be nice to document these options somehow in this file. Is this only for accumulo sever process args? Assuming it can not contain jvm args? If so could name it `server_args` which is a bit more specific. Could possibly have a `jvm_args` in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified accumulo-cluster to allow conf dir and extra args per group [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion closed pull request #5099: Modified accumulo-cluster to allow conf dir and extra args per group
URL: https://github.com/apache/accumulo/pull/5099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Modified accumulo-cluster to allow conf dir and extra args per group [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #5099:
URL: https://github.com/apache/accumulo/pull/5099#discussion_r1856891073
##########
assemble/bin/accumulo-cluster:
##########
@@ -651,28 +639,46 @@ function main() {
fi
cat <<EOF >"$conf"/cluster.yaml
manager:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
monitor:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
+ hosts:
+ - localhost
gc:
- - localhost
+ default:
+ conf_dir: /opt/accumulo/conf
+ extra_args: ""
Review Comment:
> Could possibly have a `jvm_args` in the future.
Looking at `accumulo-env.sh`, a user can supply `ACCUMULO_JAVA_OPTS` environment variable to add arguments to the JVM. However, this is added before most of the arguments, not after. So, for example, setting a JVM Xmx size in the cluster.yaml file to override the accumulo-env.sh file, would not work. If the user wants to specify some arguments that are not in the accumulo-env.sh file at all, then that would likely work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org