You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/11 16:53:46 UTC

[GitHub] [pulsar] Bklyn opened a new pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Bklyn opened a new pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798


   * Change throws of const char* to use std::exception types instead
   
   Fixes #7787
   
   ### Motivation
   
   Throw std::exception instead of `const char*`
   
   ### Modifications
   
   Should be self explanatory.
   
   ### Verifying this change
   
   This change should be covered by existing tests, such as BatchMessageTest.  Not sure about the Auth test which catches `...` however.
   
   ### Does this pull request potentially affect one of the following parts:
   
   Yes
   
     - Operations which formerly threw `const char*` now throw a type derived from `std::exception`
   
   ### Documentation
   
   The methods that can throw should be documented as such.  This was not implemented.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798#issuecomment-678135795


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798#issuecomment-678069087


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798#issuecomment-678584417


   @Bklyn Yeah, there're some flaky tests. Besides, I guess sometimes ci tests may fail because of the limited resource of docker containers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Bklyn edited a comment on pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
Bklyn edited a comment on pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798#issuecomment-678330319


   @jiazhai @BewareMyPower Are these sorts of transient test failures typical?  Thanks for the assistance!
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798#issuecomment-678088409


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Bklyn commented on pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
Bklyn commented on pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798#issuecomment-672943543


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Bklyn commented on pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
Bklyn commented on pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798#issuecomment-678330319


   @jiazhai @BewareMyPower Are these sorts of transient test failures typical?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Bklyn commented on pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
Bklyn commented on pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798#issuecomment-672186019


   Seems some tests are failing, but I didn't touch the Java code (CPP/Py tests are OK).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Bklyn removed a comment on pull request #7798: [Issue 7787][pulsar-client-cpp] Throw std::exception types

Posted by GitBox <gi...@apache.org>.
Bklyn removed a comment on pull request #7798:
URL: https://github.com/apache/pulsar/pull/7798#issuecomment-672943543


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org