You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Okomin (JIRA)" <ji...@apache.org> on 2006/12/27 10:04:21 UTC

[jira] Created: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

[classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
--------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-2886
                 URL: http://issues.apache.org/jira/browse/HARMONY-2886
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Ilya Okomin
            Priority: Minor


javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
returns valid result while RI throws NPE.

Test for reproducing:
------------- Test.java -------------
import javax.swing.plaf.basic.BasicComboBoxUI;

import junit.framework.TestCase;
import junit.textui.TestRunner;

public class test extends TestCase {

    public static void main(String args[]) {
        TestRunner.run(test.class);
    }

    public void testRun() {
        BasicComboBoxUI lb = new BasicComboBoxUI();
        BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
        try {
            b.minimumLayoutSize(null);
            fail("NPE expected");
        } catch (NullPointerException e) {
            // expected
        }
    }

}
------------------------------
Output on RI
==========
.
Time: 0.281

OK (1 test)

Output on Harmony:
================
.F
Time: 4.979
There was 1 failure:
1) testRun(test)junit.framework.AssertionFailedError: NPE expected
	at test.testRun(test.java:17)
	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
	at test.main(test.java:9)

FAILURES!!!
Tests run: 1,  Failures: 1,  Errors: 0


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oliver Deakin reassigned HARMONY-2886:
--------------------------------------

    Assignee: Oliver Deakin

> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>         Assigned To: Oliver Deakin
>            Priority: Minor
>         Attachments: Harmony-2886-Make.patch, Harmony-2886-Test.patch, Harmony-2886.patch
>
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462930 ] 

Vasily Zakharov commented on HARMONY-2886:
------------------------------------------

Attached fix and test patches.


> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>            Priority: Minor
>         Attachments: Harmony-2886-Make.patch, Harmony-2886-Test.patch, Harmony-2886.patch
>
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463948 ] 

Vasily Zakharov commented on HARMONY-2886:
------------------------------------------

Thanks, Oliver! The patch is fine. 


> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>         Assigned To: Oliver Deakin
>            Priority: Minor
>         Attachments: Harmony-2886-Make.patch, Harmony-2886-Test.patch, Harmony-2886.patch
>
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462823 ] 

Vasily Zakharov commented on HARMONY-2886:
------------------------------------------

I'll look into this issue.


> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>            Priority: Minor
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vasily Zakharov updated HARMONY-2886:
-------------------------------------

    Attachment: Harmony-2886-Make.patch
                Harmony-2886-Test.patch
                Harmony-2886.patch

> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>            Priority: Minor
>         Attachments: Harmony-2886-Make.patch, Harmony-2886-Test.patch, Harmony-2886.patch
>
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oliver Deakin closed HARMONY-2886.
----------------------------------


Verified by Vasily.

> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>         Assigned To: Oliver Deakin
>            Priority: Minor
>         Attachments: Harmony-2886-Make.patch, Harmony-2886-Test.patch, Harmony-2886.patch
>
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Ilya Okomin (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2886?page=comments#action_12460964 ] 
            
Ilya Okomin commented on HARMONY-2886:
--------------------------------------

The same result for
javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.preferredLayoutSize(null)


> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>            Priority: Minor
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Vasily Zakharov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462931 ] 

Vasily Zakharov commented on HARMONY-2886:
------------------------------------------

Attached make patch to remove javax.swing.plaf.basic.BasicComboBoxUITest from exclude list.

I'm not sure if this should be applied, as testInstallUninstallUI test case that test contains fails for now. 


> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>            Priority: Minor
>         Attachments: Harmony-2886-Make.patch, Harmony-2886-Test.patch, Harmony-2886.patch
>
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko updated HARMONY-2886:
-------------------------------------

    Patch Info: [Patch Available]

> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>            Priority: Minor
>         Attachments: Harmony-2886-Make.patch, Harmony-2886-Test.patch, Harmony-2886.patch
>
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-2886) [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oliver Deakin resolved HARMONY-2886.
------------------------------------

    Resolution: Fixed

Thanks Vasily and Ilya.
Patch applied at revision r495282. Please check that the patch applied as expected.

Note: I did not apply the exclude list patch due to the previous comment.

> [classlib][swing] Compatibility: javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null) returns valid result while RI throws NPE
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2886
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2886
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Ilya Okomin
>         Assigned To: Oliver Deakin
>            Priority: Minor
>         Attachments: Harmony-2886-Make.patch, Harmony-2886-Test.patch, Harmony-2886.patch
>
>
> javax.swing.plaf.basic.BasicComboBoxUI.ComboBoxLayoutManager.minimumLayoutSize(null)
> returns valid result while RI throws NPE.
> Test for reproducing:
> ------------- Test.java -------------
> import javax.swing.plaf.basic.BasicComboBoxUI;
> import junit.framework.TestCase;
> import junit.textui.TestRunner;
> public class test extends TestCase {
>     public static void main(String args[]) {
>         TestRunner.run(test.class);
>     }
>     public void testRun() {
>         BasicComboBoxUI lb = new BasicComboBoxUI();
>         BasicComboBoxUI.ComboBoxLayoutManager b = lb.new ComboBoxLayoutManager();
>         try {
>             b.minimumLayoutSize(null);
>             fail("NPE expected");
>         } catch (NullPointerException e) {
>             // expected
>         }
>     }
> }
> ------------------------------
> Output on RI
> ==========
> .
> Time: 0.281
> OK (1 test)
> Output on Harmony:
> ================
> .F
> Time: 4.979
> There was 1 failure:
> 1) testRun(test)junit.framework.AssertionFailedError: NPE expected
> 	at test.testRun(test.java:17)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 	at test.main(test.java:9)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira