You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2009/06/14 00:21:07 UTC

[jira] Commented: (HBASE-1503) hbase-1304 dropped updating list of store files on flush

    [ https://issues.apache.org/jira/browse/HBASE-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719187#action_12719187 ] 

stack commented on HBASE-1503:
------------------------------

Saw this w/ v2:
{code}
Caused by: java.lang.NullPointerException
        at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekAtOrAfter(StoreFileScanner.java:89)
        at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:62)
        at org.apache.hadoop.hbase.regionserver.StoreScanner.updateReaders(StoreScanner.java:211)
        at org.apache.hadoop.hbase.regionserver.Store.notifyChangedReadersObservers(Store.java:583)
        at org.apache.hadoop.hbase.regionserver.Store.updateStorefiles(Store.java:569)
        at org.apache.hadoop.hbase.regionserver.Store.flushCache(Store.java:479)
        at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:925)
        ... 3 more
{code}

> hbase-1304 dropped updating list of store files on flush
> --------------------------------------------------------
>
>                 Key: HBASE-1503
>                 URL: https://issues.apache.org/jira/browse/HBASE-1503
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1503-v1.patch, HBASE-1503-v2.patch
>
>
> Here is how current updateReaders is implemented in StoreScanner:
> {code}
>   // Implementation of ChangedReadersObserver
>   public void updateReaders() throws IOException {
>     if (this.closing.get()) {
>       return;
>     }
>     this.lock.writeLock().lock();
>     try {
>       // Could do this pretty nicely with KeyValueHeap, but the existing
>       // implementation of this method only updated if no existing storefiles?
>       // Lets discuss.
>       return;
>     } finally {
>       this.lock.writeLock().unlock();
>     }
>   }
> {code}
> Fill in missing functionality.
> Count of store files changes on flush and compaction.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.