You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by ansell <gi...@git.apache.org> on 2016/08/02 01:23:16 UTC

[GitHub] any23 pull request #27: ANY23-276 : Work on conversion to RDF4J, including b...

GitHub user ansell opened a pull request:

    https://github.com/apache/any23/pull/27

    ANY23-276 : Work on conversion to RDF4J, including bump to version 2.0

    Conversion to RDF4J isn't backwards compatible, so bumping to version 2.0 to reflect that.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ansell/any23 version2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/any23/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit a1f5e5ea07d48bffbf69f5cf2fa132b16a32c2f4
Author: Peter Ansell <p_...@yahoo.com>
Date:   2016-08-02T00:50:17Z

    ANY23-276 : Start work on converting from Sesame to RDF4J

commit d866c71d8ffee83fe962ecbc96509119af8338dc
Author: Peter Ansell <p_...@yahoo.com>
Date:   2016-08-02T01:09:26Z

    Fix remaining compile issues

commit 47ac64ebf463dd26666fb15731aaee7fd210051a
Author: Peter Ansell <p_...@yahoo.com>
Date:   2016-08-02T01:14:14Z

    Bump to version 2.0-SNAPSHOT to reflect the large changes

commit 1a084c16644a5fa444ec689d0d1cfb915b7c8d45
Author: Peter Ansell <p_...@yahoo.com>
Date:   2016-08-02T01:16:53Z

    Fix the changes to RELEASE-NOTES by grep/sed

commit bd1f787d3cc20e25fd354d249282ddbad3a72096
Author: Peter Ansell <p_...@yahoo.com>
Date:   2016-08-02T01:18:08Z

    Change property name to IRI

commit 4aacac8a02112cb819051931f3f3e87ef09ad0f4
Author: Peter Ansell <p_...@yahoo.com>
Date:   2016-08-02T01:20:56Z

    Fix encodeIRI to encodeURI

commit ce7bdbb743750f6442ae1254dd3cd48d7260beb4
Author: Peter Ansell <p_...@yahoo.com>
Date:   2016-08-02T01:22:28Z

    Fix tika configuration files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by ansell <gi...@git.apache.org>.
Github user ansell commented on the issue:

    https://github.com/apache/any23/pull/27
  
    I will work on the appassembler still being present for core and check the cli modules assembly-plugin and then merge to master.
    
    Can you do a silent retarget (no notifications sent to mailing list) of all Jira issues to 2.0 to reflect the version bump?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/27
  
    @ansell I just pulled the most recent version of this PR build and tested locally... all tests pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/27
  
    ACK @ansell I've made an addition trivial correction within the default configuration file so if you merge then we can get semargl released and upgrade then it would be great and we can put this one to bed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/27
  
    Hi @ansell this is starting to look REALLY good. I've pulled your suggestions. I did notice that the appassembler is still generated in the core/target/appassembler. I think that this can be removed based upon the suggestion for CLI to be modularized as you've implemented.
    Is there anything else you want to add to this patch? If not then I suggest we merge into master. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by ansell <gi...@git.apache.org>.
Github user ansell commented on the issue:

    https://github.com/apache/any23/pull/27
  
    Pull request to Semargl to support RDF4J has been sent:
    
    https://github.com/levkhomich/semargl/pull/45


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/27
  
    @ansell yes I will work on transitioning issues through the workflow. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by ansell <gi...@git.apache.org>.
Github user ansell commented on the issue:

    https://github.com/apache/any23/pull/27
  
    I rebased this to fix the conflicts. There are some test failures, some of which I @Ignore'd while other I left so far. Could you have a look in to see if you can figure out why the tests that have been ignored or still failing are broken?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/27
  
    ack will do @ansell thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by ansell <gi...@git.apache.org>.
Github user ansell commented on the issue:

    https://github.com/apache/any23/pull/27
  
    Okay, will fix the javadoc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/27
  
    Now getting the following when I attempt to build
    ```
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 34.292 s
    [INFO] Finished at: 2017-01-13T12:21:37-08:00
    [INFO] Final Memory: 53M/760M
    [INFO] ------------------------------------------------------------------------
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.0.0:single (assembly) on project apache-any23-cli: Error reading assemblies: No assembly descriptors found. -> [Help 1]
    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:
    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
    [ERROR]
    [ERROR] After correcting the problems, you can resume the build with the command
    [ERROR]   mvn <goals> -rf :apache-any23-cli
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by ansell <gi...@git.apache.org>.
Github user ansell commented on the issue:

    https://github.com/apache/any23/pull/27
  
    The errors are likely to be in relation to me temporarily taking out Semargl. The pull request for Semargl linked above has been accepted, but the next release has not been done for it yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 pull request #27: ANY23-276 : Work on conversion to RDF4J, including b...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/any23/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/27
  
    Hi @ansell 
    ```
    [INFO] ------------------------------------------------------------------------
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (attach-javadocs) on project apache-any23-core: MavenReportException: Error while creating archive:
    [ERROR] Exit code: 1 - /usr/local/any23/core/src/main/java/org/apache/any23/extractor/rdfa/RDFa11Parser.java:324: error: @param name not found
    [ERROR] * @param curieOrURIList list of CURIE/URI.
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/extractor/rdfa/RDFa11Parser.java:328: warning: no @param for curieOrIRIList
    [ERROR] protected IRI[] resolveCIRIeOrIRIList(Node n, String curieOrIRIList, boolean termAllowed)
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/extractor/rdfa/RDFa11Parser.java:328: warning: no @param for termAllowed
    [ERROR] protected IRI[] resolveCIRIeOrIRIList(Node n, String curieOrIRIList, boolean termAllowed)
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/extractor/rdfa/RDFa11Parser.java:364: warning: no description for @param
    [ERROR] * @param curieOrIRI
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/extractor/rdfa/XSLTStylesheet.java:62: warning: no @throws for org.apache.any23.extractor.rdfa.XSLTStylesheetException
    [ERROR] public synchronized void applyTo(Document document, Writer output)
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/extractor/rdfa/XSLTStylesheet.java:74: warning: no @throws for org.apache.any23.extractor.rdfa.XSLTStylesheetException
    [ERROR] public synchronized void applyTo(Document document, Writer output,
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/Any23ValueFactoryWrapper.java:219: warning: no description for @param
    [ERROR] * @param uri
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/Any23ValueFactoryWrapper.java:235: error: reference not found
    [ERROR] * @return a valid {@link org.openrdf.model.URI}
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/Any23ValueFactoryWrapper.java:39: error: reference not found
    [ERROR] * Any23 specialization of the {@link org.openrdf.model.ValueFactory}.
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:185: error: @param name not found
    [ERROR] * @param namespace a base namespace for the {@link IRI}
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:186: error: @param name not found
    [ERROR] * @param localName a local name to associate with the namespace
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:189: warning: no @param for uri
    [ERROR] public static IRI iri(String uri) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:198: warning: no @param for namespace
    [ERROR] public static IRI uri(String namespace, String localName) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:198: warning: no @param for localName
    [ERROR] public static IRI uri(String namespace, String localName) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:198: warning: no @return
    [ERROR] public static IRI uri(String namespace, String localName) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:205: warning: no @param for namespace
    [ERROR] public static IRI iri(String namespace, String localName) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:205: warning: no @param for localName
    [ERROR] public static IRI iri(String namespace, String localName) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:205: warning: no @return
    [ERROR] public static IRI iri(String namespace, String localName) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:313: warning: no @param for s
    [ERROR] public static Literal literal(String s, IRI datatype) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:313: warning: no @param for datatype
    [ERROR] public static Literal literal(String s, IRI datatype) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:313: warning: no @return
    [ERROR] public static Literal literal(String s, IRI datatype) {
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:414: error: reference not found
    [ERROR] * @see org.openrdf.rio.RDFFormat#values()
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:472: error: unknown tag: data
    [ERROR] * @param is input stream containing <code>RDF</data>.
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:472: error: element not closed: code
    [ERROR] * @param is input stream containing <code>RDF</data>.
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:530: error: reference not found
    [ERROR] * @throws org.openrdf.rio.RDFHandlerException if an error occurs while parsing file.
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/rdf/RDFUtils.java:531: error: reference not found
    [ERROR] * @throws org.openrdf.rio.RDFParseException if an error occurs while parsing file.
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/validator/rule/MissingItemscopeAttributeValueRule.java:32: error: reference not found
    [ERROR] * subsequently to Sesame's {@link org.semarglproject.sesame.rdf.rdfa.SesameRDFaParser},
    [ERROR] ^
    [ERROR] /usr/local/any23/core/src/main/java/org/apache/any23/writer/RDFWriterTripleHandler.java:30: error: reference not found
    [ERROR] * triples to a Sesame {@link org.openrdf.rio.RDFWriter},
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] any23 issue #27: ANY23-276 : Work on conversion to RDF4J, including bump to ...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/27
  
    Hi @ansell whats the current state of this patch? Thanks for merging in the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---