You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/31 17:07:28 UTC
[GitHub] [maven-wrapper] ArloL opened a new pull request, #67: [MWRAPPER-81] mvnw does not remove return chars from jvm.config
ArloL opened a new pull request, #67:
URL: https://github.com/apache/maven-wrapper/pull/67
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski closed pull request #67: [MWRAPPER-81] mvnw does not remove return chars from jvm.config
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski closed pull request #67: [MWRAPPER-81] mvnw does not remove return chars from jvm.config
URL: https://github.com/apache/maven-wrapper/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #67: [MWRAPPER-81] mvnw does not remove return chars from jvm.config
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #67:
URL: https://github.com/apache/maven-wrapper/pull/67#discussion_r1062378797
##########
maven-wrapper-distribution/src/resources/mvnw:
##########
@@ -160,7 +160,7 @@ find_maven_basedir() {
# concatenates all lines of a file
concat_lines() {
if [ -f "$1" ]; then
- echo "$(tr -s '\n' ' ' < "$1")"
+ echo "$(tr -s '\r\n' ' ' < "$1")"
Review Comment:
Needs to be rebased on top of https://github.com/apache/maven-wrapper/pull/79 later (removed that unnecessary echo call).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski commented on pull request #67: [MWRAPPER-81] mvnw does not remove return chars from jvm.config
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #67:
URL: https://github.com/apache/maven-wrapper/pull/67#issuecomment-1435716266
@ArloL by the way thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski commented on pull request #67: [MWRAPPER-81] mvnw does not remove return chars from jvm.config
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #67:
URL: https://github.com/apache/maven-wrapper/pull/67#issuecomment-1435716108
The same fix done by #86
I missed that is the same ... 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] ArloL commented on a diff in pull request #67: [MWRAPPER-81] mvnw does not remove return chars from jvm.config
Posted by GitBox <gi...@apache.org>.
ArloL commented on code in PR #67:
URL: https://github.com/apache/maven-wrapper/pull/67#discussion_r1082774153
##########
maven-wrapper-distribution/src/resources/mvnw:
##########
@@ -160,7 +160,7 @@ find_maven_basedir() {
# concatenates all lines of a file
concat_lines() {
if [ -f "$1" ]; then
- echo "$(tr -s '\n' ' ' < "$1")"
+ echo "$(tr -s '\r\n' ' ' < "$1")"
Review Comment:
I've updated the PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org