You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2026/10/10 19:46:54 UTC
[Impala-ASF-CR] PROTOTYPE: Estimate IS NOT NULL on CTE and inline view slots
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25088
Change subject: PROTOTYPE: Estimate IS NOT NULL on CTE and inline view slots
......................................................................
PROTOTYPE: Estimate IS NOT NULL on CTE and inline view slots
IS [NOT] NULL on a slot without a table, such as a slot of a CTE
consumer or an inline view, got the default selectivity 0.1. With CTE
suggestions in the Calcite planner, d_date_sk IS NOT NULL on a date_dim
CTE consumer cut its estimate from 274 to 27 rows, and the joins above
it broadcast 40M- and 149M-row builds in TPC-DS q17 and q25.
The predicate now follows single-SlotRef source exprs down to a table
slot and uses its null count. A slot whose stats show no NULLs gets
selectivity 1.0 for IS NOT NULL. NULLs added by outer joins inside the
view are ignored.
Testing:
- TPC-DS SF1000, 8 executors, MT_DOP=8, PLANNER=CALCITE,
CTE_THRESHOLD=1, on top of earlier prototypes: total 345.9 s ->
336.0 s; q17 and q25 no longer broadcast. No new tests.
Change-Id: I5159aa5bc69bd1ebc48939b9f65d1ff6d294d769
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/25088/1
--
To view, visit http://gerrit.cloudera.org:8080/25088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5159aa5bc69bd1ebc48939b9f65d1ff6d294d769
Gerrit-Change-Number: 25088
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE IMPALA-15674: Estimate IS NOT NULL on CTE and inline view slots
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/25088
to look at the new patch set (#2).
Change subject: PROTOTYPE IMPALA-15674: Estimate IS NOT NULL on CTE and inline view slots
......................................................................
PROTOTYPE IMPALA-15674: Estimate IS NOT NULL on CTE and inline view slots
IS [NOT] NULL on a slot without a table, such as a slot of a CTE
consumer or an inline view, got the default selectivity 0.1. With CTE
suggestions in the Calcite planner, d_date_sk IS NOT NULL on a date_dim
CTE consumer cut its estimate from 274 to 27 rows, and the joins above
it broadcast 40M- and 149M-row builds in TPC-DS q17 and q25.
The predicate now follows single-SlotRef source exprs down to a table
slot and uses its null count. A slot whose stats show no NULLs gets
selectivity 1.0 for IS NOT NULL. NULLs added by outer joins inside the
view are ignored.
Testing:
- TPC-DS SF1000, 8 executors, MT_DOP=8, PLANNER=CALCITE,
CTE_THRESHOLD=1, on top of earlier prototypes: total 345.9 s ->
336.0 s; q17 and q25 no longer broadcast. No new tests.
Change-Id: I5159aa5bc69bd1ebc48939b9f65d1ff6d294d769
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/25088/2
--
To view, visit http://gerrit.cloudera.org:8080/25088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5159aa5bc69bd1ebc48939b9f65d1ff6d294d769
Gerrit-Change-Number: 25088
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE: Estimate IS NOT NULL on CTE and inline view slots
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25088 )
Change subject: PROTOTYPE: Estimate IS NOT NULL on CTE and inline view slots
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24464/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/25088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5159aa5bc69bd1ebc48939b9f65d1ff6d294d769
Gerrit-Change-Number: 25088
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 10 Oct 2026 20:13:19 +0000
Gerrit-HasComments: No