You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/02 15:45:17 UTC

[GitHub] [skywalking-banyandb] DevPJ9 commented on a diff in pull request #203: Defining "IN" and "NOT IN" APIs in query module. Issue #9759

DevPJ9 commented on code in PR #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203#discussion_r1011968203


##########
pkg/query/logical/index_filter.go:
##########
@@ -146,6 +146,20 @@ func parseCondition(cond *model_v1.Condition, indexRule *database_v1.IndexRule,
 			and.append(newEq(indexRule, newBytesLiteral(b)))
 		}
 		return newNot(indexRule, and), []tsdb.Entity{entity}, nil
+	case model_v1.Condition_BINARY_OP_IN:
+		bb := expr.Bytes()
+		and := newOr(len(bb))

Review Comment:
   @hanahmily I have done the changes please review and let me know if any changes are needed. Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org