You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2023/01/05 11:47:25 UTC
[GitHub] [bookkeeper] horizonzy opened a new pull request, #3725: Fix newEnsemble sometimes failed problem.
horizonzy opened a new pull request, #3725:
URL: https://github.com/apache/bookkeeper/pull/3725
Descriptions of the changes in this PR:
Fixes #3722
### Motivation
See [#3722
](https://github.com/apache/bookkeeper/issues/3722#issuecomment-1369859251)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on pull request #3725: Fix RegionAwareEnsemblePlacementPolicy.newEnsemble sometimes failed problem.
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #3725:
URL: https://github.com/apache/bookkeeper/pull/3725#issuecomment-1372192221
rerun failure check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 merged pull request #3725: Fix RegionAwareEnsemblePlacementPolicy.newEnsemble sometimes failed problem.
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 merged PR #3725:
URL: https://github.com/apache/bookkeeper/pull/3725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on pull request #3725: Fix RegionAwareEnsemblePlacementPolicy.newEnsemble sometimes failed problem.
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #3725:
URL: https://github.com/apache/bookkeeper/pull/3725#issuecomment-1372977851
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on pull request #3725: Fix RegionAwareEnsemblePlacementPolicy.newEnsemble sometimes failed problem.
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #3725:
URL: https://github.com/apache/bookkeeper/pull/3725#issuecomment-1372965740
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on pull request #3725: Fix RegionAwareEnsemblePlacementPolicy.newEnsemble sometimes failed problem.
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #3725:
URL: https://github.com/apache/bookkeeper/pull/3725#issuecomment-1372192930
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on pull request #3725: Fix RegionAwareEnsemblePlacementPolicy.newEnsemble sometimes failed problem.
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #3725:
URL: https://github.com/apache/bookkeeper/pull/3725#issuecomment-1373046961
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3725: Fix RegionAwareEnsemblePlacementPolicy.newEnsemble sometimes failed problem.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3725:
URL: https://github.com/apache/bookkeeper/pull/3725#issuecomment-1434036811
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3725](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbde227) into [master](https://codecov.io/gh/apache/bookkeeper/commit/7f8c31bdad3bf7261e795feafd7f969f871baa82?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f8c31b) will **decrease** coverage by `14.82%`.
> The diff coverage is `42.85%`.
```diff
@@ Coverage Diff @@
## master #3725 +/- ##
=============================================
- Coverage 47.44% 32.62% -14.82%
+ Complexity 4558 3112 -1446
=============================================
Files 473 473
Lines 40951 40952 +1
Branches 5235 5236 +1
=============================================
- Hits 19428 13362 -6066
- Misses 19535 25920 +6385
+ Partials 1988 1670 -318
```
| Flag | Coverage Δ | |
|---|---|---|
| remaining | `29.64% <42.85%> (+0.01%)` | :arrow_up: |
| replication | `?` | |
| tls | `20.99% <0.00%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...r/client/ZoneawareEnsemblePlacementPolicyImpl.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L1pvbmVhd2FyZUVuc2VtYmxlUGxhY2VtZW50UG9saWN5SW1wbC5qYXZh) | `24.03% <0.00%> (ø)` | |
| [...org/apache/bookkeeper/net/NetworkTopologyImpl.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbmV0L05ldHdvcmtUb3BvbG9neUltcGwuamF2YQ==) | `43.36% <33.33%> (-1.18%)` | :arrow_down: |
| [...r/client/RackawareEnsemblePlacementPolicyImpl.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L1JhY2thd2FyZUVuc2VtYmxlUGxhY2VtZW50UG9saWN5SW1wbC5qYXZh) | `42.38% <66.66%> (-0.82%)` | :arrow_down: |
| [...rg/apache/bookkeeper/metastore/MetastoreTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/bookkeeper/server/conf/BookieConfiguration.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2NvbmYvQm9va2llQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../bookkeeper/metastore/MetastoreScannableTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVNjYW5uYWJsZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...bookkeeper/server/http/service/MetricsService.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9NZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...eper/server/http/service/ConfigurationService.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9Db25maWd1cmF0aW9uU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...per/bookie/storage/ldb/KeyValueStorageFactory.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL3N0b3JhZ2UvbGRiL0tleVZhbHVlU3RvcmFnZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...per/meta/LongHierarchicalLedgerManagerFactory.java](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9Mb25nSGllcmFyY2hpY2FsTGVkZ2VyTWFuYWdlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [210 more](https://codecov.io/gh/apache/bookkeeper/pull/3725?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org