You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tomasdavidorg (via GitHub)" <gi...@apache.org> on 2024/03/25 14:58:25 UTC
[PR] NO-ISSUE: Improve Minikube setup [incubator-kie-kogito-docs]
tomasdavidorg opened a new pull request, #606:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/606
<!-- Please provide a short description of what this PR does -->
**Description:**
- Removes `minikube config set cpus/memory` - this is already part of the `minikube start` command
- Splits setup to Minikube with Docker and Minikube with Podman - this would be easier for users to copy/paste the commands (the previous version needed to be modified)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Improve Minikube setup [incubator-kie-kogito-docs]
Posted by "domhanak (via GitHub)" <gi...@apache.org>.
domhanak commented on code in PR #606:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/606#discussion_r1537765715
##########
serverlessworkflow/modules/ROOT/pages/getting-started/preparing-environment.adoc:
##########
@@ -29,22 +29,36 @@ Please note, that if the knative quickstart procedure is not used, you need to i
.To startup the selected cluster without quickstart, use the following command:
[tabs]
====
-Minikube::
+Minikube with Docker::
+
--
-.Configure and startup minikube
+.Configure and startup minikube with Docker
[source,shell]
----
# Set a driver and container runtime
-minikube config set driver docker/podman
-minikube config set container-runtime docker/podman
+minikube config set driver docker
Review Comment:
the guide was trying to have both paths, with docker and podman, but I deemed it unnecessary to split using tabs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Improve Minikube setup [incubator-kie-kogito-docs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #606:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/606#issuecomment-2018204554
🎊 PR Preview 6cebb781f44cb6f4aad0711b69a826d68970b10e has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-606.surge.sh
<!-- Sticky Pull Request Comment -->
<!-- Sticky Pull Request Comment -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Improve Minikube setup [incubator-kie-kogito-docs]
Posted by "domhanak (via GitHub)" <gi...@apache.org>.
domhanak commented on code in PR #606:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/606#discussion_r1537765715
##########
serverlessworkflow/modules/ROOT/pages/getting-started/preparing-environment.adoc:
##########
@@ -29,22 +29,36 @@ Please note, that if the knative quickstart procedure is not used, you need to i
.To startup the selected cluster without quickstart, use the following command:
[tabs]
====
-Minikube::
+Minikube with Docker::
+
--
-.Configure and startup minikube
+.Configure and startup minikube with Docker
[source,shell]
----
# Set a driver and container runtime
-minikube config set driver docker/podman
-minikube config set container-runtime docker/podman
+minikube config set driver docker
Review Comment:
the guide was trying to have both paths, with docker and podman, but I deemed it unnecessary to split using tabs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Improve Minikube setup [incubator-kie-kogito-docs]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini merged PR #606:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org