You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/05 16:38:51 UTC
[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5513: [TOPI]][RELAY][MXNET]Reverse/Flip operator
siju-samuel opened a new pull request #5513:
URL: https://github.com/apache/incubator-tvm/pull/5513
reverse/flip added support for axes similar to mxnet/numpy.
@FrozenGene Please help me to review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen closed pull request #5513: [TOPI]][RELAY][MXNET]Reverse/Flip operator
Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #5513:
URL: https://github.com/apache/incubator-tvm/pull/5513
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5513: [TOPI]][RELAY][MXNET]Reverse/Flip operator
Posted by GitBox <gi...@apache.org>.
MarisaKirisame commented on pull request #5513:
URL: https://github.com/apache/incubator-tvm/pull/5513#issuecomment-652666248
@siju-samuel please rebase the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5513: [TOPI]][RELAY][MXNET]Reverse/Flip operator
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #5513:
URL: https://github.com/apache/incubator-tvm/pull/5513#discussion_r460415078
##########
File path: include/tvm/relay/attrs/transform.h
##########
@@ -174,10 +174,11 @@ struct TileAttrs : public tvm::AttrsNode<TileAttrs> {
/*! \brief Attributes used in reverse operators */
struct ReverseAttrs : public tvm::AttrsNode<ReverseAttrs> {
- Integer axis;
+ Array<Integer> axes;
Review comment:
NOTE, as per https://tvm.apache.org/docs/contribute/code_review.html#deliberate-on-api-and-data-structures we shoud always be consistent with numpy API. As a result, let us use the name axis instead. See also https://github.com/apache/incubator-tvm/blob/master/include/tvm/relay/attrs/reduce.h#L36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org