You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/23 10:48:25 UTC
[GitHub] [airflow] potiuk opened a new pull request #17783: Add warning about https configuration in SimpleHttpOperator
potiuk opened a new pull request #17783:
URL: https://github.com/apache/airflow/pull/17783
For historical reasons, configuring ``https`` via SimpleHttpOperator
is well, complex.
This PR adds warning which informs the users about it as well
provides explanation why it is like that and gives some helpful
examples, so that people do not have to look for answers in
StackOverflow questions or GitHub issues or JIRAs (as they did
so far - for example #17780 and in
https://issues.apache.org/jira/browse/AIRFLOW-2910 or
https://stackoverflow.com/questions/51630344
and many other questions.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17783: Add warning about https configuration in SimpleHttpOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17783:
URL: https://github.com/apache/airflow/pull/17783#issuecomment-904063607
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17783: Add warning about https configuration in SimpleHttpOperator
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17783:
URL: https://github.com/apache/airflow/pull/17783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org