You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/13 20:28:44 UTC
[GitHub] [cloudstack] andrijapanicsb opened a new pull request #3808: reload
dnsmasq instead of restart when adding new rules
andrijapanicsb opened a new pull request #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808
Optimistic fix, to be tested.
## Description
<!--- Describe your changes in detail -->
Reload dnsmasq when new dhcp rules are added, don't restart.
Avoids "downtime" as observed by VR monitoring scripst in environemnts with lot's of VMs being started/stopped/created in parallel, etc.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
To be tested.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-574076092
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573867320
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on a change in pull request
#3808: reload dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#discussion_r367121749
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -69,7 +69,7 @@ def process(self):
if not self.cl.is_redundant() or self.cl.is_master():
if restart_dnsmasq:
- CsHelper.service("dnsmasq", "restart")
+ CsHelper.service("dnsmasq", "reload")
Review comment:
@andrijapanicsb
"reload" works only if the service is started.
this is why we have line 74
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-574841249
Too many identical failures on 2 runes... will test manually, but it doesn't look good...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573931059
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573919944
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-576149034
ok, fair enough - closing this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-574425163
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb closed pull request #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb closed pull request #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
svenvogel commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573881524
@andrijapanicsb i think this should work. not tested but logical for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] wido commented on issue #3808: reload dnsmasq instead
of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
wido commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-574840633
Seems good to me.
@rhtyd might your experience be from an older version of dnsmasq and that this has been fixed right now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-574076210
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request
#3808: reload dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#discussion_r367183135
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -69,7 +69,7 @@ def process(self):
if not self.cl.is_redundant() or self.cl.is_master():
if restart_dnsmasq:
- CsHelper.service("dnsmasq", "restart")
+ CsHelper.service("dnsmasq", "reload")
Review comment:
I'll need to test this all @weizhouapache , but afaik dnsmasq is started when VR is created?
Do you see a problem here? (save me some time from testing all this...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573865955
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573867540
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-574424096
<b>Trillian test result (tid-769)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49789 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3808-t769-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 71 look OK, 7 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 306.83 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 364.46 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 166.57 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 208.92 | test_internal_lb.py
test_02_vpc_privategw_static_routes | `Failure` | 832.08 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 834.13 | test_privategw_acl.py
test_01_single_VPC_iptables_policies | `Error` | 794.43 | test_routers_iptables_default_policy.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 274.42 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 273.40 | test_routers_network_ops.py
test_02_redundant_VPC_default_routes | `Failure` | 970.13 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 417.11 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 443.50 | test_vpc_redundant.py
test_01_VPC_nics_after_destroy | `Failure` | 793.19 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Failure` | 793.00 | test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 407.08 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 287.54 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 328.60 | test_vpc_vpn.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573930861
damn it monkey...
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3808: reload dnsmasq instead
of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-574070120
I've tried this in the past, but then the issue was that dnsmasq doesn't read all the configs (changed files). @andrijapanicsb please test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on a change in pull request
#3808: reload dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#discussion_r367285872
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -69,7 +69,7 @@ def process(self):
if not self.cl.is_redundant() or self.cl.is_master():
if restart_dnsmasq:
- CsHelper.service("dnsmasq", "restart")
+ CsHelper.service("dnsmasq", "reload")
Review comment:
> I'll need to test this all @weizhouapache , but afaik dnsmasq is started when VR is created?
@andrijapanicsb it seems dnsmasq is disabled in routers. it will be started when dnsmasq.conf is generated.
https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/common.sh#L588-L595
> Do you see a problem here? (save me some time from testing all this...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-574714097
<b>Trillian test result (tid-774)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55531 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3808-t774-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 70 look OK, 8 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 323.55 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 388.20 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 180.95 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 228.75 | test_internal_lb.py
test_04_extract_Iso | `Failure` | 1.06 | test_iso.py
test_02_vpc_privategw_static_routes | `Failure` | 857.62 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 850.88 | test_privategw_acl.py
test_01_single_VPC_iptables_policies | `Error` | 802.04 | test_routers_iptables_default_policy.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 299.07 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 290.84 | test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 489.85 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Failure` | 994.12 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 435.34 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 460.23 | test_vpc_redundant.py
test_01_VPC_nics_after_destroy | `Failure` | 804.90 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Failure` | 812.01 | test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 443.05 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 323.09 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 339.62 | test_vpc_vpn.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573857153
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573857326
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573857087
reload does work fine when /etc/dhcphosts.txt is changed, and it does issue a new IP (changed IP in there for the sake of the quick test, before this PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3808: reload
dnsmasq instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-574424926
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3808: reload dnsmasq
instead of restart when adding new rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#issuecomment-573920053
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services