[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request #1378: HDDS-4133. Use new ContainerManager in SCM.

[GitBox <gi...@apache.org>]

nandakumar131 commented on a change in pull request #1378:
URL: https://github.com/apache/hadoop-ozone/pull/1378#discussion_r496149425



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerID.java
##########
@@ -41,8 +41,8 @@
    * @param id int
    */
   private ContainerID(long id) {
-    Preconditions.checkState(id > 0,
-        "Container ID should be a positive. %s.", id);
+    Preconditions.checkState(id >= 0,

Review comment:
       We don't create a container with ID 0, but 0 is a valid ID.
   The reason for allowing 0 as a value for container ID is to avoid the explicit null check that we do in HDDS-1302.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org