[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

[mike-jumper <gi...@git.apache.org>]

Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-manual/pull/66#discussion_r155416416
  
    --- Diff: src/chapters/jdbc-auth.xml ---
    @@ -299,6 +321,60 @@ Type "help" for help.
                         to run any database upgrade scripts.</para>
                 </important>
             </section>
    +        <section xml:id="jdbc-auth-sqlserver">
    +            <title>SQL Server</title>
    +            <para>If using SQL Server, the database and schema must be created first.  The example below assumes
    +                that you are running SQL Server on Linux, using the command-line tools to manage it.</para>
    +            <informalexample>
    +                <screen><prompt>$</prompt> <userinput>/opt/mssql-tools/bin/sqlcmd -S localhost -U SA</userinput>
    +<prompt>Password:</prompt> <userinput><replaceable>password</replaceable></userinput>
    +<prompt>1></prompt> <userinput>CREATE DATABASE <replaceable>guacamole_db</replaceable>;</userinput>
    +<prompt>2></prompt> <userinput>GO</userinput>
    +<prompt>1></prompt> <userinput>CREATE LOGIN <replaceable>guacamole_user</replaceable> WITH PASSWORD = '<replaceable>S0me_Password</replaceable>';</userinput>
    +<prompt>2></prompt> <userinput>GO</userinput>
    +<prompt>1></prompt> <userinput>USE <replaceable>guacamole_db</replaceable>;</userinput>
    +<prompt>2></prompt> <userinput>GO</userinput>
    +<prompt>1></prompt> <userinput>CREATE USER <replaceable>guacamole_user</replaceable>;</userinput>
    +<prompt>2></prompt> <userinput>GO</userinput>
    +<prompt>1></prompt> <userinput>ALTER ROLE db_datawriter ADD MEMBER <replaceable>guacamole_user</replaceable>;</userinput>
    +<prompt>1></prompt> <userinput>ALTER ROLE db_datareader ADD MEMBER <replaceable>guacamole_user</replaceable>;</userinput>
    --- End diff --
    
    I don't have access to this at the moment to test, but based on the prompt pattern above, I'm surprised that the prompt before both of the `ALTER` statements is `1`. Does it keep incrementing until `GO`? Or is it truly `1` for both statements in this case?


---