[GitHub] [iceberg] samredai edited a comment on pull request #3677: Python: Adding TableMetadata object from dict, bytestream, and s3 sources

[GitBox <gi...@apache.org>]

samredai edited a comment on pull request #3677:
URL: https://github.com/apache/iceberg/pull/3677#issuecomment-1030135791


   I think this is ready for another look. I've rebased with the commits from the file io PR that was merged. The table metadata class has a `from_input_file` and `to_output_file` method that takes an `InputFile` or `OutputFile` instance.
   
   Another thing I did was move the `LocalFileIO`, `LocalInputFile`, and `LocalOutputFile` implementations to `conftest.py` as a fixture that can be used across all tests (see the docstring at the top of `conftest.py` for more details).
   
   If we can settle on the design here, I think a thorough inspection of the V1 and V2 jsonschemas defined here is needed before merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org