Re: Review Request 50591: RANGER-1124:Code changes to avoid potential NPEs and good coding practices in hbase-agent, hdfs-agent, hive-agent, knox-agent, plugin-kafka, plugin-nifi, plugin-solr, ranger-plugin-classloader, agents-audit - medium risk

[Madhan Neethiraj <ma...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50591/#review144197
-----------------------------------------------------------




agents-audit/src/main/java/org/apache/ranger/audit/provider/hdfs/HdfsLogDestination.java 
<https://reviews.apache.org/r/50591/#comment210210>

    Is this issue flagged by scan?



hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java (line 256)
<https://reviews.apache.org/r/50591/#comment210205>

    Replace "admin.listTables(tableNameMatching)" with "htds".



hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java (line 90)
<https://reviews.apache.org/r/50591/#comment210203>

    The fix does not address the warning flagged:  "Useless/non-informative string generated (FB.DMI_INVOKING_TOSTRING_ON_ARRAY)
    1. defect: Invocation of toString on fileStats.".
    
    Instead consider replacing:
      "+ fileStats +"
    with
      "+ (fileStats != null ? fileStats.length : 0) + " files ""



hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java (line 686)
<https://reviews.apache.org/r/50591/#comment210201>

    This fix does not seem necessary.
    Instead review line #684 to handle the case "maskTypeDef == null".


- Madhan Neethiraj


On July 29, 2016, 2:59 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50591/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 2:59 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-1124:Code changes to avoid potential NPEs and good coding practices in hbase-agent, hdfs-agent, hive-agent, knox-agent, plugin-kafka, plugin-nifi, plugin-solr, ranger-plugin-classloader, agents-audit - medium risk
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java c6cd8b2 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 9da97ed 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 46f33a5 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java e3e818c 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java a671165 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 8ad4616 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/hdfs/HdfsLogDestination.java 0951c64 
>   agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditBatchQueue.java 5b56c96 
>   agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java 17ddab9 
>   hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 65e7be6 
>   hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java bc98d24 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java bfe1891 
>   plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 1afedd5 
>   plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java 9371eaa 
>   ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoaderUtil.java ea18883 
> 
> Diff: https://reviews.apache.org/r/50591/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>