You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "abhioncbr (via GitHub)" <gi...@apache.org> on 2023/06/10 21:32:59 UTC
[GitHub] [pinot] abhioncbr opened a new issue, #10890: Update ReplicaGroupPartitionConfig & ReplicaGroupStrategyConfig validation for partitionColumn
abhioncbr opened a new issue, #10890:
URL: https://github.com/apache/pinot/issues/10890
Labels: bugfix
Recently, we introduced the `partitionColumn` field in config `ReplicaGroupPartitionConfig` and the validation logic. Here is the PR for [reference](https://github.com/apache/pinot/pull/10656)
The [validation](https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java#L616) checks that `ReplicaGroupPartitionConfig` and `ReplicaGroupStrategyConfig` should not be present for the table. For backward compatibility, we should ensure that validation fails only if both configs have a different value of `partitionColumn`; otherwise, not.
Notes:
- As per the [implementation](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java#L455), if both configs have the `partitionColumn` value, it will be picked from `ReplicaGroupPartitionConfig`.
- This validation is to avoid confusion about the value used.
cc: @Jackie-Jiang @tibrewalpratik17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr closed issue #10890: Update ReplicaGroupPartitionConfig & ReplicaGroupStrategyConfig validation for partitionColumn
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr closed issue #10890: Update ReplicaGroupPartitionConfig & ReplicaGroupStrategyConfig validation for partitionColumn
URL: https://github.com/apache/pinot/issues/10890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] tibrewalpratik17 commented on issue #10890: Update ReplicaGroupPartitionConfig & ReplicaGroupStrategyConfig validation for partitionColumn
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on issue #10890:
URL: https://github.com/apache/pinot/issues/10890#issuecomment-1585823718
@abhioncbr looks like a small change. Can you assign this to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr commented on issue #10890: Update ReplicaGroupPartitionConfig & ReplicaGroupStrategyConfig validation for partitionColumn
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on issue #10890:
URL: https://github.com/apache/pinot/issues/10890#issuecomment-1590016938
I that case, we can close this issue as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10890: Update ReplicaGroupPartitionConfig & ReplicaGroupStrategyConfig validation for partitionColumn
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10890:
URL: https://github.com/apache/pinot/issues/10890#issuecomment-1589821230
I closed #10877 because I think the validation might be okay as it only blocks new uploaded configs. It will force users to use the new `partitionColumn` within the `ReplicaGroupPartitionConfig`, which is desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org