You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by m4rkmckenna <gi...@git.apache.org> on 2017/01/16 10:40:12 UTC
[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL
GitHub user m4rkmckenna opened a pull request:
https://github.com/apache/brooklyn-library/pull/84
Updates zookeeper download URL
Fastbull is not longer a valid download URL for zookeeper ... changed to apache hosted
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/m4rkmckenna/brooklyn-library bugfix/zookeeper-download-url
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit d928bd6338907d1d2ef3bfe028ad77f0043f85af
Author: Mark McKenna <m4...@gmail.com>
Date: 2017-01-16T10:39:15Z
Updates zookeeper download URL
Fastbull is not longer a valid download URL for zookeeper ... changed to apache hosted
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/84#discussion_r96203007
--- Diff: software/messaging/src/main/java/org/apache/brooklyn/entity/zookeeper/ZooKeeperNode.java ---
@@ -46,7 +46,7 @@
@SetFromFlag("downloadUrl")
AttributeSensorAndConfigKey<String, String> DOWNLOAD_URL = ConfigKeys.newSensorAndConfigKeyWithDefault(SoftwareProcess.DOWNLOAD_URL,
- "http://apache.fastbull.org/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
+ "http://apache.org/dist/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
--- End diff --
Do we not want to use: `www.apache.org/dyn/closer.cgi?filename=zookeeper/zookeeper-3.4.9/zookeeper-3.4.9.tar.gz&action=download` as described [here](http://www.apache.org/dev/release-download-pages#closer)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/84#discussion_r96201981
--- Diff: software/messaging/src/main/java/org/apache/brooklyn/entity/zookeeper/ZooKeeperNode.java ---
@@ -46,7 +46,7 @@
@SetFromFlag("downloadUrl")
AttributeSensorAndConfigKey<String, String> DOWNLOAD_URL = ConfigKeys.newSensorAndConfigKeyWithDefault(SoftwareProcess.DOWNLOAD_URL,
- "http://apache.fastbull.org/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
+ "http://apache.org/dist/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
--- End diff --
From `http://apache.org/dist/`:
`Please do not download from apache.org! If you are currently at apache.org and would like to browse, please visit a nearby mirror site instead.`
Would be fine though if we add the binary to cloudsoft's mirror - it's queried first, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/84#discussion_r96202857
--- Diff: software/messaging/src/main/java/org/apache/brooklyn/entity/zookeeper/ZooKeeperNode.java ---
@@ -46,7 +46,7 @@
@SetFromFlag("downloadUrl")
AttributeSensorAndConfigKey<String, String> DOWNLOAD_URL = ConfigKeys.newSensorAndConfigKeyWithDefault(SoftwareProcess.DOWNLOAD_URL,
- "http://apache.fastbull.org/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
+ "http://apache.org/dist/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
--- End diff --
@neykov Mirrors come and go where as this site will always be present ... I think it is a smart default
The reason this has broke is because it previously relied on a thirdparty
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/84#discussion_r96203094
--- Diff: software/messaging/src/main/java/org/apache/brooklyn/entity/zookeeper/ZooKeeperNode.java ---
@@ -46,7 +46,7 @@
@SetFromFlag("downloadUrl")
AttributeSensorAndConfigKey<String, String> DOWNLOAD_URL = ConfigKeys.newSensorAndConfigKeyWithDefault(SoftwareProcess.DOWNLOAD_URL,
- "http://apache.fastbull.org/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
+ "http://apache.org/dist/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
--- End diff --
Agree, but we should avoid putting load on apache.org if possible, by mirroring the binary in cloudsoft.com.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/84#discussion_r96203420
--- Diff: software/messaging/src/main/java/org/apache/brooklyn/entity/zookeeper/ZooKeeperNode.java ---
@@ -46,7 +46,7 @@
@SetFromFlag("downloadUrl")
AttributeSensorAndConfigKey<String, String> DOWNLOAD_URL = ConfigKeys.newSensorAndConfigKeyWithDefault(SoftwareProcess.DOWNLOAD_URL,
- "http://apache.fastbull.org/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
+ "http://apache.org/dist/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
--- End diff --
Great suggestion @drigodwin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #84: Updates zookeeper download URL
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/84#discussion_r96203547
--- Diff: software/messaging/src/main/java/org/apache/brooklyn/entity/zookeeper/ZooKeeperNode.java ---
@@ -46,7 +46,7 @@
@SetFromFlag("downloadUrl")
AttributeSensorAndConfigKey<String, String> DOWNLOAD_URL = ConfigKeys.newSensorAndConfigKeyWithDefault(SoftwareProcess.DOWNLOAD_URL,
- "http://apache.fastbull.org/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
+ "http://apache.org/dist/zookeeper/zookeeper-${version}/zookeeper-${version}.tar.gz");
--- End diff --
awesome @drigodwin ill amend now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #84: Updates zookeeper download URL
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-library/pull/84
Looks good, thanks @m4rkmckenna
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---