You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/02/23 20:35:34 UTC
[GitHub] [arrow] kou opened a new pull request, #34317: GH-34308: [CI][C++] Use str("") to reset std::stringstream for old g++
kou opened a new pull request, #34317:
URL: https://github.com/apache/arrow/pull/34317
### Rationale for this change
Error log:
FAILED: src/arrow/CMakeFiles/arrow-array-test.dir/array/array_run_end_test.cc.o
g++ ... -std=c++17 -c /arrow/cpp/src/arrow/array/array_run_end_test.cc
/arrow/cpp/src/arrow/array/array_run_end_test.cc: In member
function 'virtual void
arrow::{anonymous}::TestRunEndEncodedArray_Printing_Test::TestBody()':
/arrow/cpp/src/arrow/array/array_run_end_test.cc:580:9: error:
converting to 'std::__cxx11::basic_stringstream<char>' from
initializer list would use explicit constructor
'std::__cxx11::basic_stringstream<
_CharT,
_Traits,
_Alloc
>::basic_stringstream(std::ios_base::openmode)
[with _CharT = char;
_Traits = std::char_traits<char>;
_Alloc = std::allocator<char>;
std::ios_base::openmode = std::_Ios_Openmode]' [-Werror]
ss = {};
^
...
cc1plus: all warnings being treated as errors
### What changes are included in this PR?
This pull request uses `str("")` instead of `= {}` like other tests.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34317: GH-34308: [CI][C++] Use str("") to reset std::stringstream for old g++
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34317:
URL: https://github.com/apache/arrow/pull/34317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34317: GH-34308: [CI][C++] Use str("") to reset std::stringstream for old g++
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34317:
URL: https://github.com/apache/arrow/pull/34317#issuecomment-1442397030
@github-actions crossbow submit test-debian-10-cpp-* test-ubuntu-18.04-cpp*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34317: GH-34308: [CI][C++] Use str("") to reset std::stringstream for old g++
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34317:
URL: https://github.com/apache/arrow/pull/34317#issuecomment-1442396782
* Closes: #34308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34317: GH-34308: [CI][C++] Use str("") to reset std::stringstream for old g++
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34317:
URL: https://github.com/apache/arrow/pull/34317#issuecomment-1442396829
:warning: GitHub issue #34308 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34317: GH-34308: [CI][C++] Use str("") to reset std::stringstream for old g++
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34317:
URL: https://github.com/apache/arrow/pull/34317#issuecomment-1443971729
Benchmark runs are scheduled for baseline = 8c70ddf6054a0091f44c80b9cb49d12fe61b9d30 and contender = 4064757272d33174098f9dec86d5a3a5327bc0af. 4064757272d33174098f9dec86d5a3a5327bc0af is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2e7247bbf7c24745b2ab52256beb3887...dc62a2ca4a9d42a1a5a6a836ae348b17/)
[Finished :arrow_down:0.37% :arrow_up:0.09%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a1b8c7a6f6b04d3bb14541a88335a5be...94089c9a359c47e8abb97c34fd8cfe53/)
[Finished :arrow_down:1.28% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b4be293a1b57425cba95c4e239a3fc7c...340dbd008b39416a8828ffd2c27e87be/)
[Finished :arrow_down:0.35% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0adc14e6d35e4435b4867260f2985906...f33f8ced01a54434ae872937a9efb7b8/)
Buildkite builds:
[Finished] [`40647572` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2431)
[Finished] [`40647572` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2461)
[Finished] [`40647572` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2428)
[Finished] [`40647572` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2452)
[Finished] [`8c70ddf6` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2430)
[Finished] [`8c70ddf6` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2460)
[Finished] [`8c70ddf6` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2427)
[Finished] [`8c70ddf6` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2451)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34317: GH-34308: [CI][C++] Use str("") to reset std::stringstream for old g++
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34317:
URL: https://github.com/apache/arrow/pull/34317#issuecomment-1443973553
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b4be293a1b57425cba95c4e239a3fc7c...340dbd008b39416a8828ffd2c27e87be/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34317: GH-34308: [CI][C++] Use str("") to reset std::stringstream for old g++
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34317:
URL: https://github.com/apache/arrow/pull/34317#issuecomment-1442399453
Revision: f22688931292c84c86914c124255f5a8632cd86a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5371c86e21](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5371c86e21)
|Task|Status|
|----|------|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4256637864/jobs/7405767139)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4256637179/jobs/7405766216)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4256639304/jobs/7405769857)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4256639700/jobs/7405770590)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4256638748/jobs/7405768881)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34317: GH-34308: [CI][C++] Use str("") to reset std::stringstream for old g++
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34317:
URL: https://github.com/apache/arrow/pull/34317#issuecomment-1442801775
+1
The `test-ubuntu-18.04-cpp` failure isn't unrelated: #34324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org