[GitHub] [pinot] klsince commented on a diff in pull request #10785: [WIP] allow env var substibution for Pinot configs

["klsince (via GitHub)" <gi...@apache.org>]

klsince commented on code in PR #10785:
URL: https://github.com/apache/pinot/pull/10785#discussion_r1199417840


##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java:
##########
@@ -357,6 +358,9 @@ public long getProperty(String name, long defaultValue) {
    */
   public String getProperty(String name, String defaultValue) {
     Object rawProperty = getRawProperty(name, defaultValue);

Review Comment:
   yeah, why not. lemme update



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org