You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/06 15:53:59 UTC
[GitHub] [incubator-eventmesh] walterlife opened a new pull request, #1232: [ISSUE #1092,#1091] java sdk add workflow/catalog client
walterlife opened a new pull request, #1232:
URL: https://github.com/apache/incubator-eventmesh/pull/1232
Fixes #1091 #1092 .
### Motivation
Applications can access the EventMesh Workflow/AysncAPI capabilities through the EventMesh SDK to fill the event governance capabilities
### Modifications
1. add workflow grpc client
2. add catalog grpc client
3. add nacos naming selector
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] walterlife commented on pull request #1232: [ISSUE #1092,#1091] java sdk add workflow/catalog client
Posted by GitBox <gi...@apache.org>.
walterlife commented on PR #1232:
URL: https://github.com/apache/incubator-eventmesh/pull/1232#issuecomment-1238847189
> @walterlife hi，this pr may be too big to review, can you split it into several small prs?
ok, plan to split four, protocol, workflow-client, catalog-client, nacos-selector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] walterlife closed pull request #1232: [ISSUE #1092,#1091] java sdk add workflow/catalog client
Posted by GitBox <gi...@apache.org>.
walterlife closed pull request #1232: [ISSUE #1092,#1091] java sdk add workflow/catalog client
URL: https://github.com/apache/incubator-eventmesh/pull/1232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1232: [ISSUE #1092,#1091] java sdk add workflow/catalog client
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1232:
URL: https://github.com/apache/incubator-eventmesh/pull/1232#issuecomment-1238381484
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1232](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e996fb) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/67ee6661e45d3f29e7ec10b2a6ed578465fcf1de?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67ee666) will **decrease** coverage by `0.58%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 0e996fb differs from pull request most recent head 63f92ff. Consider uploading reports for the commit 63f92ff to get more accurate results
```diff
@@ Coverage Diff @@
## master #1232 +/- ##
============================================
- Coverage 10.92% 10.33% -0.59%
- Complexity 730 758 +28
============================================
Files 403 439 +36
Lines 24346 26619 +2273
Branches 2680 2925 +245
============================================
+ Hits 2659 2752 +93
- Misses 21430 23604 +2174
- Partials 257 263 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/java/org/apache/eventmesh/common/Constants.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9Db25zdGFudHMuamF2YQ==) | `85.71% <ø> (ø)` | |
| [...sh/common/protocol/catalog/protos/CatalogGrpc.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9DYXRhbG9nR3JwYy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../protocol/catalog/protos/EventmeshCatalogGrpc.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9FdmVudG1lc2hDYXRhbG9nR3JwYy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...mesh/common/protocol/catalog/protos/Operation.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9PcGVyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rotocol/catalog/protos/QueryOperationsRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9RdWVyeU9wZXJhdGlvbnNSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...otocol/catalog/protos/QueryOperationsResponse.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9RdWVyeU9wZXJhdGlvbnNSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ommon/protocol/catalog/protos/RegistryRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9SZWdpc3RyeVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mmon/protocol/catalog/protos/RegistryResponse.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9SZWdpc3RyeVJlc3BvbnNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rotocol/workflow/protos/EventmeshWorkflowGrpc.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC93b3JrZmxvdy9wcm90b3MvRXZlbnRtZXNoV29ya2Zsb3dHcnBjLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ommon/protocol/workflow/protos/ExecuteRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC93b3JrZmxvdy9wcm90b3MvRXhlY3V0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1232/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #1232: [ISSUE #1092,#1091] java sdk add workflow/catalog client
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on PR #1232:
URL: https://github.com/apache/incubator-eventmesh/pull/1232#issuecomment-1238828344
@walterlife hi，this pr may be too big to review, can you split it into several small prs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] walterlife commented on pull request #1232: [ISSUE #1092,#1091] java sdk add workflow/catalog client
Posted by GitBox <gi...@apache.org>.
walterlife commented on PR #1232:
URL: https://github.com/apache/incubator-eventmesh/pull/1232#issuecomment-1238846982
> @walterlife hi，this pr may be too big to review, can you split it into several small prs?
ok, plan to split four, protocol, workflow-client, catalog-client, nacos-selector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org