[GitHub] [hudi] danny0405 commented on a diff in pull request #5937: [HUDI-4298] When reading the mor table with QUERY_TYPE_SNAPSHOT,Unabl…

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #5937:
URL: https://github.com/apache/hudi/pull/5937#discussion_r903665178


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java:
##########
@@ -753,7 +758,7 @@ private Option<IndexedRecord> mergeRowWithLog(
         String curKey) throws IOException {
       final HoodieAvroRecord<?> record = (HoodieAvroRecord) scanner.getRecords().get(curKey);
       GenericRecord historyAvroRecord = (GenericRecord) rowDataToAvroConverter.convert(tableSchema, curRow);
-      return record.getData().combineAndGetUpdateValue(historyAvroRecord, tableSchema);
+      return record.getData().combineAndGetUpdateValue(historyAvroRecord, tableSchema, payloadConf);

Review Comment:
   Nice catch, can we write a test case in `TestWriteMergeOnRead` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org