You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TheBosZ <gi...@git.apache.org> on 2016/02/23 19:00:28 UTC
[GitHub] cordova-plugin-camera pull request: Create Pictures directory if i...
GitHub user TheBosZ opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/178
Create Pictures directory if it doesn't exist.
Possibly should throw an exception if the directory can't be created. A log message is emitted and behavior is no worse than current code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheBosZ/cordova-plugin-camera patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #178
----
commit df1ac44916863acedf3643093024fdfdccc5122e
Author: Nathan <na...@gmail.com>
Date: 2016-02-23T17:59:50Z
Create Pictures directory if it doesn't exist.
Possibly should throw an exception if the directory can't be created. A log message is emitted and behavior is no worse than current code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...
Posted by DavidKuennen <gi...@git.apache.org>.
Github user DavidKuennen commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/178
Oh, I didn't know that! Thanks die Tage Info.
Am 17.05.2017 5:40 nachm. schrieb "Nathan" <no...@github.com>:
> @DavidKuennen <https://github.com/davidkuennen> It's really pretty easy
> to fork this plugin, update the code and then just specify the fork in your
> config.xml.
>
> That's what I do when I need a change to a plugin that the authors don't
> want to incorporate.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cordova-plugin-camera/pull/178#issuecomment-302130954>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AHaCJY4B_NXjYeEvRjIEr-SRRYWYM_MQks5r6xTXgaJpZM4Hg3jH>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/178
Which device doesn't have this folder? Also, for some reason this failed Travis. Can you clean up the conficts, create a JIRA issue and provide more details for the repro? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/178
@DavidKuennen It's really pretty easy to fork this plugin, update the code and then just specify the fork in your config.xml.
That's what I do when I need a change to a plugin that the authors don't want to incorporate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/178
FWIW I had this problem when using an Android emulator but forgot to specify the SD card size in its AVD definition. In that situation, the emulator acts like the SD card is mounted in read-only mode and thus the `/storage/sdcard` mount is empty (and lacks the expected `./Pictures` subdirectory).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/178
It probably failed because this branch is out of date.
I can't for the life of me remember the exact device this happened to.
It's a very straightforward fix, but I've moved on. If you don't want/need this, feel free to close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...
Posted by DavidKuennen <gi...@git.apache.org>.
Github user DavidKuennen commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/178
We constantly have this error whenever we update this plugin (we have to modify the plugin ourself to create the folder if it doesn't exist). It's be awesome if this would be fixed in the original.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org