[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2878: [CALCITE-5241] Implement CHAR function

[GitBox <gi...@apache.org>]

JiajunBernoulli commented on code in PR #2878:
URL: https://github.com/apache/calcite/pull/2878#discussion_r954958773


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -1492,9 +1492,6 @@ protected static Calendar getCalendarNotTooNear(int timeUnit) {
     f.checkScalar("{fn ASCII('ABC')}", "65", "INTEGER NOT NULL");
     f.checkNull("{fn ASCII(cast(null as varchar(1)))}");
 
-    if (false) {
-      f.checkScalar("{fn CHAR(code)}", null, "");
-    }

Review Comment:
   Sorry, I misunderstood the meaning of your sentence (test the JDBC function separately from the char function).  
   Should I save this test and change it to useful tests.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org