You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by GitBox <gi...@apache.org> on 2021/02/01 21:27:13 UTC

[GitHub] [db-jdo-site] tzaeschke opened a new pull request #21: Remove svn references for specification PDFs

tzaeschke opened a new pull request #21:
URL: https://github.com/apache/db-jdo-site/pull/21


   This PR fix the links for the specification PDFs to point to the GitHub repository instead of the SVN repository.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [db-jdo-site] tzaeschke merged pull request #21: Remove svn references for specification PDFs

Posted by GitBox <gi...@apache.org>.
tzaeschke merged pull request #21:
URL: https://github.com/apache/db-jdo-site/pull/21


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [db-jdo-site] tobous commented on a change in pull request #21: Remove svn references for specification PDFs

Posted by GitBox <gi...@apache.org>.
tobous commented on a change in pull request #21:
URL: https://github.com/apache/db-jdo-site/pull/21#discussion_r568801305



##########
File path: src/main/asciidoc/specifications.adoc
##########
@@ -12,10 +12,10 @@
 The following specifications for JDO are available
 
 * The
-http://svn.apache.org/viewvc/db/jdo/trunk/specification/OOO/JDO-3.1.pdf?view=co[JDO
+https://github.com/apache/db-jdo/tree/master/specification/OOO/JDO-3.1.pdf?view=co[JDO

Review comment:
       As a minor note in case we keep the current links: I don't think the ending `?view=co` does anything for PDFs in the GitHub view. It is automatically dropped for me when following the link.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [db-jdo-site] tzaeschke merged pull request #21: Remove svn references for specification PDFs

Posted by GitBox <gi...@apache.org>.
tzaeschke merged pull request #21:
URL: https://github.com/apache/db-jdo-site/pull/21


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [db-jdo-site] tobous commented on a change in pull request #21: Remove svn references for specification PDFs

Posted by GitBox <gi...@apache.org>.
tobous commented on a change in pull request #21:
URL: https://github.com/apache/db-jdo-site/pull/21#discussion_r568801305



##########
File path: src/main/asciidoc/specifications.adoc
##########
@@ -12,10 +12,10 @@
 The following specifications for JDO are available
 
 * The
-http://svn.apache.org/viewvc/db/jdo/trunk/specification/OOO/JDO-3.1.pdf?view=co[JDO
+https://github.com/apache/db-jdo/tree/master/specification/OOO/JDO-3.1.pdf?view=co[JDO

Review comment:
       As a minor note in case we keep the current links: I don't think the ending `?view=co` does anything for PDFs in the GitHub view. It is automatically dropped for me when following the link.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org