You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/16 19:21:19 UTC

[GitHub] [spark] srowen commented on a change in pull request #26911: Remove usage of Guava that breaks in 27; replace with workalikes

srowen commented on a change in pull request #26911: Remove usage of Guava that breaks in 27; replace with workalikes
URL: https://github.com/apache/spark/pull/26911#discussion_r358415147
 
 

 ##########
 File path: common/network-common/src/main/java/org/apache/spark/network/protocol/ChunkFetchFailure.java
 ##########
 @@ -54,7 +57,7 @@ public static ChunkFetchFailure decode(ByteBuf buf) {
 
   @Override
   public int hashCode() {
-    return Objects.hashCode(streamChunkId, errorString);
+    return Objects.hash(streamChunkId, errorString);
 
 Review comment:
   Work-alikes from java.util; should do the same thing as it calls Arrays.hashCode in both cases

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org