You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/09/20 06:58:22 UTC

[GitHub] spark pull request #22483: [MINOR][PYTHON] Use a helper in `PythonUtils` ins...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/22483

    [MINOR][PYTHON] Use a helper in `PythonUtils` instead of direct accessing Scala package

    ## What changes were proposed in this pull request?
    
    This PR proposes to use add a helper in `PythonUtils` instead of direct accessing Scala package.
    
    ## How was this patch tested?
    
    Jenkins tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark minor-refactoring

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22483
    
----
commit cce9d4d1bb6c297e15dbec5b53f8ed3163e88d9c
Author: hyukjinkwon <gu...@...>
Date:   2018-09-20T06:34:54Z

    Minor refactoring

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22483: [MINOR][PYTHON] Use a helper in `PythonUtils` instead of...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22483
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22483: [MINOR][PYTHON] Use a helper in `PythonUtils` instead of...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22483
  
    **[Test build #96331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96331/testReport)** for PR 22483 at commit [`cce9d4d`](https://github.com/apache/spark/commit/cce9d4d1bb6c297e15dbec5b53f8ed3163e88d9c).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22483: [MINOR][PYTHON] Use a helper in `PythonUtils` instead of...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22483
  
    Merged to master, branch-2.4 and branch-2.3.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22483: [MINOR][PYTHON] Use a helper in `PythonUtils` instead of...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22483
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3285/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22483: [MINOR][PYTHON] Use a helper in `PythonUtils` instead of...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22483
  
    cc @squito and @felixcheung I am taking a look to reuse it first in a similar patch. Looks we better fix it whether it's reused or not.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22483: [MINOR][PYTHON] Use a helper in `PythonUtils` instead of...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22483
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22483: [MINOR][PYTHON] Use a helper in `PythonUtils` instead of...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22483
  
    **[Test build #96331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96331/testReport)** for PR 22483 at commit [`cce9d4d`](https://github.com/apache/spark/commit/cce9d4d1bb6c297e15dbec5b53f8ed3163e88d9c).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22483: [MINOR][PYTHON] Use a helper in `PythonUtils` instead of...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22483
  
    I am getting this in to other branches. Should be safe to go.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org