You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "13627105546 (via GitHub)" <gi...@apache.org> on 2026/01/14 07:50:40 UTC

[PR] net/icmp: Fix devif_loopback dead loop when unrecognized ICMP packet [nuttx]

13627105546 opened a new pull request, #17890:
URL: https://github.com/apache/nuttx/pull/17890

   
   *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   
   When an unrecognized ICMP (type=3, code=2) packet is received, the ICMP flow does not set dev->d_len to 0, causing a devif_loopback dead loop.
   
   Therefore, in ICMP input processing, when an ICMP_DEST_UNREACHABLE message is received, if it is not ICMP_FRAG_NEEDED code, jump to typeerr for proper error handling.
   
   ## Impact
   
   Fixes a endless loop in devif_loopback when handling unrecognized ICMP packets (specifically type 3, code 2). This improves system stability when facing unexpected network traffic.
   
   ## Testing
   
   Verified with ICMP packets (type=3, code=2). The system no longer enters a dead loop and correctly handles the error.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] net/icmp: Fix devif_loopback dead loop when unrecognized ICMP packet [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao merged PR #17890:
URL: https://github.com/apache/nuttx/pull/17890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org