[GitHub] [superset] michael-s-molina commented on a diff in pull request #24703: feat: migrate charts on import

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on code in PR #24703:
URL: https://github.com/apache/superset/pull/24703#discussion_r1265222611


##########
superset/migrations/shared/migrate_viz/processors.py:
##########
@@ -51,6 +51,9 @@ def _pre_action(self) -> None:
             self.data["show_extra_controls"] = True
             self.data["stack"] = stacked_map.get(stacked)
 
+        if x_axis := self.data.get("granularity_sqla"):
+            self.data["x_axis"] = x_axis

Review Comment:
   @betodealmeida The Area chart migration is incomplete and the ECharts version contains many bugs related to the Advanced Analytics section. That's why we skipped Area and Line migrations in 3.0. If you check [this](https://github.com/apache/superset/pull/23870) and [this](https://github.com/apache/superset/pull/23973) you'll see that the migration on master is missing many fields. I suggest skipping this migration for the Area chart when importing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org