You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/07/18 08:53:18 UTC
[GitHub] [submarine] MortalHappiness opened a new pull request #684: SUBMARINE-945. Create helm chart for submarine operator
MortalHappiness opened a new pull request #684:
URL: https://github.com/apache/submarine/pull/684
### What is this PR for?
Create helm chart for submarine operator
### What type of PR is it?
[Feature]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-945
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kevin85421 commented on pull request #684: SUBMARINE-945. Create helm chart for submarine operator
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #684:
URL: https://github.com/apache/submarine/pull/684#issuecomment-886040166
LGTM @pingsutw Do you have any other recommendations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] MortalHappiness commented on a change in pull request #684: SUBMARINE-945. Create helm chart for submarine operator
Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on a change in pull request #684:
URL: https://github.com/apache/submarine/pull/684#discussion_r671845229
##########
File path: submarine-cloud-v2/helm-charts/submarine-operator/.helmignore
##########
@@ -0,0 +1,23 @@
+# Patterns to ignore when building packages.
Review comment:
@pingsutw I have added the license, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #684: SUBMARINE-945. Create helm chart for submarine operator
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #684:
URL: https://github.com/apache/submarine/pull/684#discussion_r671840281
##########
File path: submarine-cloud-v2/helm-charts/submarine-operator/.helmignore
##########
@@ -0,0 +1,23 @@
+# Patterns to ignore when building packages.
Review comment:
Need to add the license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #684: SUBMARINE-945. Create helm chart for submarine operator
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #684:
URL: https://github.com/apache/submarine/pull/684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org