You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/06/14 13:31:38 UTC

[GitHub] [arrow] raulcd opened a new pull request, #36063: GH-35635: [C++][CI] Preserve root when when ignoring host on PathFromUriHelper to fix HDFS tests

raulcd opened a new pull request, #36063:
URL: https://github.com/apache/arrow/pull/36063

   ### Rationale for this change
   
   As discussed on the issue the HDFS filesystem should be returning `/` if the entire path is `/`
   
   ### What changes are included in this PR?
   
   Change behavior of helper `PathFromUriHelper` when ignoring host to preserve `/`
   
   ### Are these changes tested?
   
   On CI and archery.
   
   ### Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] westonpace merged pull request #36063: GH-35635: [C++][CI] Preserve root when ignoring host on PathFromUriHelper to fix HDFS tests

Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace merged PR #36063:
URL: https://github.com/apache/arrow/pull/36063


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] raulcd commented on pull request #36063: GH-35635: [C++][CI] Preserve root when ignoring host on PathFromUriHelper to fix HDFS tests

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #36063:
URL: https://github.com/apache/arrow/pull/36063#issuecomment-1591371800

   @westonpace do you think this approach is ok?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] raulcd commented on pull request #36063: GH-35635: [C++][CI] Preserve root when when ignoring host on PathFromUriHelper to fix HDFS tests

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #36063:
URL: https://github.com/apache/arrow/pull/36063#issuecomment-1591218210

   @github-actions crossbow submit test*hdfs*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #36063: GH-35635: [C++][CI] Preserve root when when ignoring host on PathFromUriHelper to fix HDFS tests

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36063:
URL: https://github.com/apache/arrow/pull/36063#issuecomment-1591222274

   Revision: 902203d9969e539eeaa9e69b9ff098ee7f10809a
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-b0ca0b5418](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b0ca0b5418)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.10-hdfs-2.9.2|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-b0ca0b5418-github-test-conda-python-3.10-hdfs-2.9.2)](https://github.com/ursacomputing/crossbow/actions/runs/5267836571/jobs/9523628398)|
   |test-conda-python-3.10-hdfs-3.2.1|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-b0ca0b5418-github-test-conda-python-3.10-hdfs-3.2.1)](https://github.com/ursacomputing/crossbow/actions/runs/5267835655/jobs/9523626422)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36063: GH-35635: [C++][CI] Preserve root when ignoring host on PathFromUriHelper to fix HDFS tests

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36063:
URL: https://github.com/apache/arrow/pull/36063#issuecomment-1600728168

   Conbench analyzed the 6 benchmark runs on commit `f959a2e0`.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/14436618511) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org