[GitHub] [hudi] nsivabalan commented on a diff in pull request #5401: [HUDI-3947] Fixing Hive conf usage in HoodieSparkSqlWriter

[GitBox <gi...@apache.org>]

nsivabalan commented on code in PR #5401:
URL: https://github.com/apache/hudi/pull/5401#discussion_r856558443


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -619,11 +618,8 @@ object HoodieSparkSqlWriter {
       properties.put(HoodieSyncConfig.META_SYNC_SPARK_VERSION.key, SPARK_VERSION)
       properties.put(HoodieSyncConfig.META_SYNC_USE_FILE_LISTING_FROM_METADATA.key, hoodieConfig.getBoolean(HoodieMetadataConfig.ENABLE))
 
-      val hiveConf: HiveConf = new HiveConf()
-      hiveConf.addResource(fs.getConf)
-
       syncClientToolClassSet.foreach(impl => {
-        SyncUtilHelpers.runHoodieMetaSync(impl.trim, properties, hiveConf, fs, basePath.toString, baseFileFormat)
+        SyncUtilHelpers.runHoodieMetaSync(impl.trim, properties, fs.getConf, fs, basePath.toString, baseFileFormat)

Review Comment:
   Note to reviewer: Initially thought of adding docs here. but HiveConf is not really required, bcoz SyncUtilHelpers.runHoodieMetaSync() expects only HadoopConf as 3rd argument. So, didn't feel a need to add docs around the fix. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org