You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/14 14:47:10 UTC

[GitHub] [arrow] pachamaltese commented on pull request #10020: ARROW-12370: [R] Bindings for power kernel

pachamaltese commented on pull request #10020:
URL: https://github.com/apache/arrow/pull/10020#issuecomment-819575897


   > Looks good. Should we also add a test of calling it through `dplyr`, just to be sure/explicit? (The answer may be no.)
   > 
   > Should we test with other data types as well? Not that we need R tests for this, but just to confirm that the C++ implementation is doing what it should with types other than float64?
   
   sure ! adding now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org