You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by ka...@apache.org on 2013/04/24 14:22:35 UTC

svn commit: r1471382 - in /db/derby/code/trunk/java/engine/org/apache/derby: iapi/db/TriggerExecutionContext.java impl/sql/catalog/DDColumnDependableFinder.java impl/sql/execute/InternalTriggerExecutionContext.java

Author: kahatlen
Date: Wed Apr 24 12:22:35 2013
New Revision: 1471382

URL: http://svn.apache.org/r1471382
Log:
DERBY-6169: Reduce visibility of classes and methods under impl/sql

Remove unused methods and make DDColumnDependableFinder's constructor
package private.

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/db/TriggerExecutionContext.java
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DDColumnDependableFinder.java
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/InternalTriggerExecutionContext.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/db/TriggerExecutionContext.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/iapi/db/TriggerExecutionContext.java?rev=1471382&r1=1471381&r2=1471382&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/iapi/db/TriggerExecutionContext.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/db/TriggerExecutionContext.java Wed Apr 24 12:22:35 2013
@@ -83,16 +83,6 @@ public interface TriggerExecutionContext
 	public String getEventStatementText();
 
 	/**
-	 * Get the columns that have been modified by the statement
-	 * that caused this trigger to fire.  If all columns are
-	 * modified, will return null (e.g. for INSERT or DELETE
-	 * return null).
-	 *
-	 * @return an array of Strings
-	 */
-	public String[] getModifiedColumns();
-
-	/**
 	 * Find out if a column was changed, by column name.
 	 *
 	 * @param columnName the column to check

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DDColumnDependableFinder.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DDColumnDependableFinder.java?rev=1471382&r1=1471381&r2=1471382&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DDColumnDependableFinder.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DDColumnDependableFinder.java Wed Apr 24 12:22:35 2013
@@ -70,7 +70,7 @@ public class DDColumnDependableFinder ex
 	/**
 	 * Constructor given referenced column bit map byte array as in FormatableBitSet
 	 */
-	public  DDColumnDependableFinder(int formatId, byte[] columnBitMap)
+    DDColumnDependableFinder(int formatId, byte[] columnBitMap)
 	{
 		super(formatId);
 		this.columnBitMap = columnBitMap;
@@ -83,28 +83,6 @@ public class DDColumnDependableFinder ex
     ////////////////////////////////////////////////////////////////////////
 
 	/**
-	 * Get the byte array encoding the bitmap of referenced columns in
-	 * a table.
-	 *
-	 * @return		byte array as in a FormatableBitSet encoding column bit map
-	 */
-	public 	byte[]	getColumnBitMap()
-	{
-		return columnBitMap;
-	}
-
-	/**
-	 * Set the byte array encoding the bitmap of referenced columns in
-	 * a table.
-	 *
-	 * @param	columnBitMap	byte array as in a FormatableBitSet encoding column bit map
-	 */
-	public	void	setColumnBitMap(byte[] columnBitMap)
-	{
-		this.columnBitMap = columnBitMap;
-	}
-
-	/**
 	 * Find a dependable object, which is essentially a table descriptor with
 	 * referencedColumnMap field set.
 	 *

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/InternalTriggerExecutionContext.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/InternalTriggerExecutionContext.java?rev=1471382&r1=1471381&r2=1471382&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/InternalTriggerExecutionContext.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/InternalTriggerExecutionContext.java Wed Apr 24 12:22:35 2013
@@ -396,19 +396,6 @@ class InternalTriggerExecutionContext
 	}
 
 	/**
-	 * Get the columns that have been modified by the statement
-	 * that caused this trigger to fire.  If all columns are
-	 * modified, will return null (e.g. for INSERT or DELETE will
-	 * return null).
-	 *
-	 * @return an array of Strings
-	 */
-	public String[] getModifiedColumns()
-	{
-		return changedColNames;
-	}
-
-	/**
 	 * Find out of a column was changed, by column name
 	 *
 	 * @param columnName the column to check