You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/07/15 12:58:43 UTC
[GitHub] [ozone] adoroszlai commented on a diff in pull request #5071: HDDS-8186. Ozone Client to accept replication config from params or config.
adoroszlai commented on code in PR #5071:
URL: https://github.com/apache/ozone/pull/5071#discussion_r1264350571
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java:
##########
@@ -109,8 +110,12 @@ public void execute(OzoneClient client, OzoneAddress address)
}
}
- replication.fromParams(getConf()).ifPresent(config ->
- bb.setDefaultReplicationConfig(new DefaultReplicationConfig(config)));
+ ReplicationConfig replicationConfig =
+ replication.fromParamsOrConfig(getConf());
+ if (replicationConfig != null) {
+ bb.setDefaultReplicationConfig(
+ new DefaultReplicationConfig(replicationConfig));
+ }
Review Comment:
Bucket-level replication config should be set only if explicitly specified via params. Otherwise it is left unset, and should fall back at server-side to the cluster-level default replication setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org