[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4397: Add support for listing partition recursively during the table migration

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #4397:
URL: https://github.com/apache/iceberg/pull/4397#discussion_r835695260



##########
File path: data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java
##########
@@ -133,6 +132,20 @@ private TableMigrationUtil() {
     }
   }
 
+  private static List<FileStatus> listStatus(Configuration conf, String partitionUri) throws IOException {

Review comment:
       Since we have the conf here, couldn't we use the same option that Hive uses? I also think it is probably safe to just always be recursive?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org