You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2019/12/03 18:39:19 UTC
[geode] 01/01: GEODE-7519 GMSHealthMonitorJUnitTest fails in
testCheckIfAvailableNoHeartBeatDontRemoveMember
This is an automated email from the ASF dual-hosted git repository.
bschuchardt pushed a commit to branch feature/GEODE-7519
in repository https://gitbox.apache.org/repos/asf/geode.git
commit 017fa778a5a6d243ffa8c811b85455c4dc9a385d
Author: Bruce Schuchardt <bs...@pivotal.io>
AuthorDate: Tue Dec 3 10:33:05 2019 -0800
GEODE-7519 GMSHealthMonitorJUnitTest fails in testCheckIfAvailableNoHeartBeatDontRemoveMember
Removing time-sensitive test. There are other tests that already
exercise the checkIfAvailable health-monitor method. Two of those tests make
sure that the initiateRemoval parameter (the last parameter) to
checkIfAvailable functions properly and that the value returned by the
method is correct. Other tests already ensure that a member that
checks out okay is not removed from the cluster and that the value
returned by checkIfAvailable is correct.
---
.../membership/gms/fd/GMSHealthMonitorJUnitTest.java | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java b/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java
index 9144c20..f70baaa 100644
--- a/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java
+++ b/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java
@@ -450,25 +450,6 @@ public class GMSHealthMonitorJUnitTest {
Assert.assertTrue(gmsHealthMonitor.getStats().getSuspectsReceived() > 0);
}
- /***
- * validates HealthMonitor.CheckIfAvailable api
- */
- @Test
- public void testCheckIfAvailableNoHeartBeatDontRemoveMember() {
- useGMSHealthMonitorTestClass = true;
- simulateHeartbeatInGMSHealthMonitorTestClass = false;
-
- installAView();
-
- long startTime = System.currentTimeMillis();
- boolean retVal = gmsHealthMonitor.checkIfAvailable(mockMembers.get(1), "Not responding", true);
- long timeTaken = System.currentTimeMillis() - startTime;
-
- assertFalse("CheckIfAvailable should have return false", retVal);
- assertTrue("This should have taken member ping timeout 100ms but it took " + timeTaken,
- timeTaken >= gmsHealthMonitor.memberTimeout);
- }
-
@Test
public void testCheckIfAvailableWithSimulatedHeartBeat() {
GMSMembershipView v = installAView();