You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by jianlirong <gi...@git.apache.org> on 2015/11/05 07:21:35 UTC
[GitHub] incubator-hawq pull request: HAWQ-117. Add query dispatching conte...
GitHub user jianlirong opened a pull request:
https://github.com/apache/incubator-hawq/pull/75
HAWQ-117. Add query dispatching context checking before serialization
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jianlirong/incubator-hawq HAWQ-117
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit cf5e6018134ef0d2c57fa0b148c6876950e46450
Author: Lirong Jian <ji...@gmail.com>
Date: 2015-11-05T06:10:38Z
HAWQ-117. Add query dispatching context checking before serialization
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-117. Add query dispatching conte...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/75#discussion_r44376635
--- Diff: src/backend/cdb/cdbcopy.c ---
@@ -207,7 +207,7 @@ cdbCopyStart(CdbCopy *c, char *copyCmd, Oid relid, Oid relerror, List *err_aoseg
((CopyStmt *)q->utilityStmt)->scantable_splits = scantable_splits;
}
- CloseQueryContextInfo(q->contextdisp);
+ FinalizeQueryContextInfo(q->contextdisp);
--- End diff --
The indention needs to followed here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-117. Add query dispatching conte...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/75#issuecomment-155642515
Looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-117. Add query dispatching conte...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/75#issuecomment-155345237
The fix looks good to me. It would be better if the minor revision regarding indention can be fixed. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-117. Add query dispatching conte...
Posted by jianlirong <gi...@git.apache.org>.
Github user jianlirong closed the pull request at:
https://github.com/apache/incubator-hawq/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---