You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Alex Deparvu (JIRA)" <ji...@apache.org> on 2019/03/22 09:45:01 UTC

[jira] [Commented] (OAK-8159) GroupPrincipalWrapper.getName is redundant

    [ https://issues.apache.org/jira/browse/OAK-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798858#comment-16798858 ] 

Alex Deparvu commented on OAK-8159:
-----------------------------------

good one, it's true it's not needed.

> GroupPrincipalWrapper.getName is redundant
> ------------------------------------------
>
>                 Key: OAK-8159
>                 URL: https://issues.apache.org/jira/browse/OAK-8159
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: security-spi
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>         Attachments: OAK-8159.patch
>
>
> [~stillalex], i just noticed that {{GroupPrincipalWrapper.getName}} is redundant... spottet it while writing additional tests and found that {{getName}} is called twice when mocking the {{Group}} that is wrapped. See attached test and patch. Wdyt?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)