You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/20 02:59:05 UTC
[GitHub] [shardingsphere] dongzl opened a new pull request #7854: Add SQLServer with, top, output clause for delete statement.
dongzl opened a new pull request #7854:
URL: https://github.com/apache/shardingsphere/pull/7854
For #6478 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #7854: Add SQLServer with, top, output clause for delete statement.
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #7854:
URL: https://github.com/apache/shardingsphere/pull/7854#discussion_r508943890
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/DMLStatement.g4
##########
@@ -57,7 +57,7 @@ assignmentValue
;
delete
- : DELETE (singleTableClause | multipleTablesClause) whereClause?
+ : withClause_? DELETE top? (singleTableClause | multipleTablesClause) outputClause_? whereClause?
Review comment:
@dongzl plz change `withClause_` to `withClause`,`outputClause_` to `outputClause`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on pull request #7854: Add SQLServer with, top, output clause for delete statement.
Posted by GitBox <gi...@apache.org>.
dongzl commented on pull request #7854:
URL: https://github.com/apache/shardingsphere/pull/7854#issuecomment-712908220
> @dongzl can you add the UT?
Hi @jingshanglu , yes, it is necessary to add the UT for the code, I plan to add it in next PR, Because I have only a few scattered time for this work, I want to split the work into several PRs, Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on pull request #7854: Add SQLServer with, top, output clause for delete statement.
Posted by GitBox <gi...@apache.org>.
dongzl commented on pull request #7854:
URL: https://github.com/apache/shardingsphere/pull/7854#issuecomment-712631890
> Hi @dongzl Thanks for polishing. :)
> BTW, please give a look at #7856. `withClause_` is expected to be renamed.
Hi @tristaZero ,Thank you for your reminder, this PR only add SQLServer `with`, `top` and `output` grammar, I want to remove the `_` at next PR for all the SQLServer g4 file according to #7856 . Do you think this is OK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on pull request #7854: Add SQLServer with, top, output clause for delete statement.
Posted by GitBox <gi...@apache.org>.
dongzl commented on pull request #7854:
URL: https://github.com/apache/shardingsphere/pull/7854#issuecomment-713625553
This PR conflict with `master`, close and resubmit a new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl closed pull request #7854: Add SQLServer with, top, output clause for delete statement.
Posted by GitBox <gi...@apache.org>.
dongzl closed pull request #7854:
URL: https://github.com/apache/shardingsphere/pull/7854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on pull request #7854: Add SQLServer with, top, output clause for delete statement.
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on pull request #7854:
URL: https://github.com/apache/shardingsphere/pull/7854#issuecomment-712752034
@dongzl can you add the UT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl edited a comment on pull request #7854: Add SQLServer with, top, output clause for delete statement.
Posted by GitBox <gi...@apache.org>.
dongzl edited a comment on pull request #7854:
URL: https://github.com/apache/shardingsphere/pull/7854#issuecomment-712908220
> @dongzl can you add the UT?
Hi @jingshanglu , yes, it is necessary to add the UT for the code, I plan to add it in next PR, Because I have only a few fragmentary time for this work, I want to split the work into several PRs, Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org