You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/09/04 16:23:53 UTC
Re: Review Request 37821: Join threads in libprocess when shutting
down.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 2:23 p.m.)
Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and switched to 'mcypark'.
Changes
-------
Rebase.
Bugs: MESOS-3158
https://issues.apache.org/jira/browse/MESOS-3158
Repository: mesos
Description
-------
Join threads in libprocess when shutting down.
Diffs (updated)
-----
3rdparty/libprocess/src/event_loop.hpp 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30
3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840
3rdparty/libprocess/src/libevent.cpp ee7906470069b0391dde7cd685b1d4eb3a158c03
3rdparty/libprocess/src/process.cpp 755187c8761137cb2bf2f7295b29a63f63c68bc6
Diff: https://reviews.apache.org/r/37821/diff/
Testing
-------
After configuring with both "../configure" and "../configure --enable-libevent --enable-ssl":
make check
Also, to check for race conditions related to the initialization/shutdown of libprocess, try something like:
for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests --gtest_filter=ProcessTest.Spawn; done
Thanks,
Greg Mann
Re: Review Request 37821: Join threads in libprocess when shutting
down.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review97758
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37821]
All tests passed.
- Mesos ReviewBot
On Sept. 4, 2015, 2:23 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37821/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 2:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-3158
> https://issues.apache.org/jira/browse/MESOS-3158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Join threads in libprocess when shutting down.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/event_loop.hpp 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30
> 3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840
> 3rdparty/libprocess/src/libevent.cpp ee7906470069b0391dde7cd685b1d4eb3a158c03
> 3rdparty/libprocess/src/process.cpp 755187c8761137cb2bf2f7295b29a63f63c68bc6
>
> Diff: https://reviews.apache.org/r/37821/diff/
>
>
> Testing
> -------
>
> After configuring with both "../configure" and "../configure --enable-libevent --enable-ssl":
>
> make check
>
>
> Also, to check for race conditions related to the initialization/shutdown of libprocess, try something like:
>
> for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests --gtest_filter=ProcessTest.Spawn; done
>
>
> Thanks,
>
> Greg Mann
>
>