[GitHub] [camel-k] jamesnetherton commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming

[GitBox <gi...@apache.org>]

jamesnetherton commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r320349853
 
 

 ##########
 File path: pkg/cmd/install.go
 ##########
 @@ -74,6 +74,7 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions) *cobra.Command {
 	cmd.Flags().StringVar(&impl.buildStrategy, "build-strategy", "", "Set the build strategy")
 	cmd.Flags().StringVar(&impl.buildTimeout, "build-timeout", "", "Set how long the build process can last")
 	cmd.Flags().StringVar(&impl.traitProfile, "trait-profile", "", "The profile to use for traits")
+	cmd.Flags().BoolVar(&impl.cache, "cache", true, "To enable or disable the cache in building phase")
 
 Review comment:
   'cache' is perhaps a bit too vague as a flag name. Maybe align it with the other build related flags. E.g `build-cache`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services